oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Force set to process properties in insertion order.

Browse source 
Note, we should look for a way to make this more efficient.
This commit is contained in:
Colin Kuskie 2009-12-18 15:28:10 -08:00
parent 8837185bce
commit 030f6bccf0
2 changed files with 39 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
lib/WebGUI/Definition/Role/Object.pm
View file

@ -86,9 +86,10 @@ is not an attribute of the object, then it is silently ignored.
sub set { sub set {
my $self = shift; my $self = shift;
my $properties = @_ % 2 ? shift : { @_ }; my $properties = @_ % 2 ? shift : { @_ };
KEY: for my $key ( keys %$properties ) { my @orderedProperties = $self->getProperties;
next KEY unless $self->meta->find_attribute_by_name($key); KEY: for my $property ( @orderedProperties ) {
$self->$key($properties->{$key}); next KEY unless exists $properties->{$property};
$self->$property($properties->{$property});
} }
return 1; return 1;
} }

35
t/Definition.t
View file

@ -61,3 +61,38 @@ my $called_getProperties;
} }
{
package WGT::Class2;
use WebGUI::Definition;
attribute 'attribute1' => 'attribute1 value';
property 'property3' => ( label => 'label' );
property 'property1' => ( label => 'label' );
property 'property2' => ( label => 'label' );
my @set_order = ();
before 'property1' => sub {
my $self = shift;
push @set_order, '1';
};
before 'property2' => sub {
my $self = shift;
push @set_order, '2';
};
before 'property3' => sub {
my $self = shift;
push @set_order, '3';
};
my $object = WGT::Class2->new();
$object->set(property1 => 1, property2 => 0, property3 => 1);
::cmp_deeply( [ @set_order ], [3,1,2], 'properties set in insertion order');
@set_order = ();
$object->set(property2 => 1, property3 => 0, property1 => 1);
::cmp_deeply( [ @set_order ], [3,1,2], '... and again');
}