oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Uniqueness check on attribute names in get_property_list. Add tests for that, and for get_attributes

Browse source
This commit is contained in:
Colin Kuskie 2009-12-11 11:56:16 -08:00
parent 334f3414c3
commit 059bd6761d
2 changed files with 35 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/WebGUI/Definition/Meta/Class.pm
View file

@ -67,12 +67,14 @@ Returns an array reference of the names of all properties, in the order they wer
=cut =cut
sub get_property_list { sub get_property_list {
my $self = shift; my $self = shift;
my @properties = (); my @properties = ();
my %seen = ();
CLASS: foreach my $className (reverse $self->linearized_isa()) { CLASS: foreach my $className (reverse $self->linearized_isa()) {
my $meta = $self->initialize($className); my $meta = $self->initialize($className);
next CLASS unless $meta->isa('WebGUI::Definition::Meta::Class'); next CLASS unless $meta->isa('WebGUI::Definition::Meta::Class');
push @properties, push @properties,
grep { ! $seen{$_}++ } # Uniqueness check
map { $_->name } # Just the name map { $_->name } # Just the name
sort { $a->insertion_order <=> $b->insertion_order } # In insertion order sort { $a->insertion_order <=> $b->insertion_order } # In insertion order
grep { $_->isa('WebGUI::Definition::Meta::Property') } # that are Meta::Properties grep { $_->isa('WebGUI::Definition::Meta::Property') } # that are Meta::Properties

32
t/Definition.t
View file

@ -115,6 +115,18 @@ my $called_getProperties;
package main; package main;
cmp_bag(
[ map {$_->name} WGT::Class::AlsoAsset->meta->get_attributes ],
[qw/property1 property2 property3/],
'get_attributes returns attributes for my class'
);
cmp_bag(
[ map {$_->name} WGT::Class::Asset::Snippet->meta->get_attributes ],
[qw/property10 property11/],
'...even in a subclass'
);
cmp_deeply( cmp_deeply(
WGT::Class::Asset::Snippet->getProperties, WGT::Class::Asset::Snippet->getProperties,
[qw/property1 property2 property3 property10 property11/], [qw/property1 property2 property3 property10 property11/],
@ -122,3 +134,23 @@ my $called_getProperties;
); );
} }
{
package WGT::Class::Asset::NotherOne;
use WebGUI::Definition::Asset;
extends 'WGT::Class::AlsoAsset';
attribute tableName => 'snippet';
property 'property10' => ();
property 'property1' => ();
package main;
cmp_deeply(
WGT::Class::Asset::NotherOne->getProperties,
[qw/property1 property2 property3 property10/],
'checking inheritance of properties by name, insertion order with an overridden property'
);
}