oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

all loop iterators have to be declared lexical. PBP/108

Browse source
This commit is contained in:
Colin Kuskie 2007-12-05 16:46:38 +00:00
parent 52132e61f4
commit 08fbd46d28
8 changed files with 31 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

8
lib/WebGUI/Image/Graph/Pie.pm
View file

@ -398,7 +398,7 @@ Draws the pie chart.
=cut
sub draw {
my ($currentSlice, $coordinates, $sliceData, $leftPlaneVisible, $rightPlaneVisible);
my ($currentSlice, $coordinates, $leftPlaneVisible, $rightPlaneVisible);
my $self = shift;
$self->processDataset;
@ -407,7 +407,7 @@ sub draw {
my @slices = sort sortSlices @{$self->{_slices}};
# First draw the bottom planes and the labels behind the chart.
foreach $sliceData (@slices) {
foreach my $sliceData (@slices) {
# Draw bottom
$self->drawBottom($sliceData);
@ -419,7 +419,7 @@ sub draw {
# Second draw the sides
# If angle == 0 do a 2d pie
if ($self->getTiltAngle != 0) {
foreach $sliceData (@slices) { #(sort sortSlices @{$self->{_slices}}) {
foreach my $sliceData (@slices) { #(sort sortSlices @{$self->{_slices}}) {
$leftPlaneVisible = (_mod2pi($sliceData->{startAngle}) <= 0.5*pi || _mod2pi($sliceData->{startAngle} >= 1.5*pi));
$rightPlaneVisible = (_mod2pi($sliceData->{stopAngle}) >= 0.5*pi && _mod2pi($sliceData->{stopAngle} <= 1.5*pi));
@ -446,7 +446,7 @@ sub draw {
}
# Finally draw the top planes of each slice and the labels that are in front of the chart.
foreach $sliceData (@slices) {
foreach my $sliceData (@slices) {
$self->drawTop($sliceData) if ($self->getTiltAngle != 0);
if (_mod2pi($sliceData->{avgAngle}) > pi) {

4
lib/WebGUI/Image/Graph/XYGraph/Bar.pm
View file

@ -123,7 +123,7 @@ Draws all the bars.
=cut
sub drawGraph {
my ($currentBar, %location);
my %location;
my $self = shift;
$self->processDataSet;
@ -137,7 +137,7 @@ sub drawGraph {
$location{x} = $self->getChartOffset->{x} ;
$location{y} = $self->getChartOffset->{y} + $self->getChartHeight;
foreach $currentBar (@{$self->{_bars}}) {
foreach my $currentBar (@{$self->{_bars}}) {
if ($self->getDrawMode eq 'stacked') {
$self->drawStackedBar($currentBar, \%location, $barWidth);
} else {