From 0f9064a8ab18f63c2fc77b3306f4ff0140da6f1a Mon Sep 17 00:00:00 2001
From: Martin Kamerbeek <martin@webgui-svn>
Date: Fri, 12 Aug 2005 17:59:16 +0000
Subject: [PATCH] Cleaning up some left over unnamed parameter in Form methods.

---
 lib/WebGUI/Operation/Commerce.pm       |  5 +++-
 lib/WebGUI/Operation/ProductManager.pm | 34 ++++++++++++++++++++------
 lib/WebGUI/Operation/Subscription.pm   | 20 ++++++++++++---
 3 files changed, 46 insertions(+), 13 deletions(-)

diff --git a/lib/WebGUI/Operation/Commerce.pm b/lib/WebGUI/Operation/Commerce.pm
index 772e3f4b7..14efe8d44 100644
--- a/lib/WebGUI/Operation/Commerce.pm
+++ b/lib/WebGUI/Operation/Commerce.pm
@@ -169,7 +169,10 @@ sub www_checkoutConfirm {
 	$plugin = WebGUI::Commerce::Payment->load(WebGUI::Session::getScratch('paymentGateway'));
 
 	$f = WebGUI::HTMLForm->new;
-	$f->hidden('op', 'checkoutSubmit');
+	$f->hidden(
+		-name => 'op', 
+		-value => 'checkoutSubmit'
+		);
 	$f->raw($plugin->checkoutForm);
 	$f->submit(value=>$i18n->get('pay button'));
 	
diff --git a/lib/WebGUI/Operation/ProductManager.pm b/lib/WebGUI/Operation/ProductManager.pm
index c7f5e52ab..94b11d661 100755
--- a/lib/WebGUI/Operation/ProductManager.pm
+++ b/lib/WebGUI/Operation/ProductManager.pm
@@ -85,8 +85,14 @@ sub www_editProduct {
 	}
 	
 	$f = WebGUI::HTMLForm->new;
-	$f->hidden('op', 'editProductSave');
-	$f->hidden('productId', $productId);
+	$f->hidden(
+		-name => 'op', 
+		-value => 'editProductSave'
+		);
+	$f->hidden(
+		-name => 'productId', 
+		-value => $productId
+	);
 	$f->text(
 		-name		=> 'title',
 		-label		=> $i18n->get('title'),
@@ -356,8 +362,14 @@ sub www_editProductVariant {
 	$variant = WebGUI::Product->getByVariantId($variantId)->getVariant($variantId);
 	
 	$f = WebGUI::HTMLForm->new;
-	$f->hidden('op', 'editProductVariantSave');
-	$f->hidden('variantId', $variantId);
+	$f->hidden(
+		-name => 'op', 
+		-value => 'editProductVariantSave'
+	);
+	$f->hidden(
+		-name => 'variantId', 
+		-value => $variantId
+	);
 	$f->readOnly(
 		-label	=> $i18n->get('variant ID'),
 		-value	=> $variant->{variantId}
@@ -422,8 +434,14 @@ sub www_editSkuTemplate {
 	$output .= "</ul><br>";
 	
 	$f = WebGUI::HTMLForm->new;
-	$f->hidden('op', 'editSkuTemplateSave');
-	$f->hidden('productId', $productId);
+	$f->hidden(
+		-name => 'op', 
+		-value => 'editSkuTemplateSave'
+		);
+	$f->hidden(
+		-name => 'productId', 
+		-value => $productId
+		);
 	$f->text(
 		-name	=> 'skuTemplate',
 		-value	=> $product->get('skuTemplate'),
@@ -531,8 +549,8 @@ sub www_listProductVariants {
 		$output .= "</tr>";
 	}
 	$output .= "</table>";
-	$output .= WebGUI::Form::submit;
-	$output .= WebGUI::Form::formFooter;
+	$output .= WebGUI::Form::submit();
+	$output .= WebGUI::Form::formFooter();
 
 	return _submenu($output, 'list variants label', 'list variants', 'ProductManager');
 }
diff --git a/lib/WebGUI/Operation/Subscription.pm b/lib/WebGUI/Operation/Subscription.pm
index a7f85cb9d..6d87722ab 100644
--- a/lib/WebGUI/Operation/Subscription.pm
+++ b/lib/WebGUI/Operation/Subscription.pm
@@ -64,7 +64,10 @@ sub www_createSubscriptionCodeBatch {
 	%subscriptions = WebGUI::SQL->buildHash("select subscriptionId, name from subscription where deleted != 1 order by name");
 	
 	$f = WebGUI::HTMLForm->new;
-	$f->hidden('op', 'createSubscriptionCodeBatchSave');
+	$f->hidden(
+		-name => 'op', 
+		-value => 'createSubscriptionCodeBatchSave'
+		);
 	$f->integer(
 		-name	=> 'noc',
 		-label	=> $i18n->get('noc'),
@@ -190,8 +193,14 @@ sub www_editSubscription {
 	$subscriptionId = $session{form}{sid} || 'new';
 
 	$f = WebGUI::HTMLForm->new;
-	$f->hidden('op', 'editSubscriptionSave');
-	$f->hidden('sid', $subscriptionId);
+	$f->hidden(
+		-name => 'op', 
+		-value => 'editSubscriptionSave'
+		);
+	$f->hidden(
+		-name => 'sid', 
+		-value => $subscriptionId
+	);
 	$f->readOnly(
 		-label	=> $i18n->get('subscriptionId'),
 		-value	=> $subscriptionId
@@ -431,7 +440,10 @@ sub www_redeemSubscriptionCode {
 	}
 	
 	$f = WebGUI::HTMLForm->new;
-	$f->hidden('op','redeemSubscriptionCode');
+	$f->hidden(
+		-name => 'op',
+		-value => 'redeemSubscriptionCode'
+		);
 	$f->text(
 		-name		=> 'code',
 		-label		=> $i18n->get('code'),