oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

added robustness to user services. added tests

Browse source
This commit is contained in:
Doug Bell 2009-05-15 22:27:36 +00:00
parent 5f60eddaa7
commit 1617e3004f
2 changed files with 486 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

23
lib/WebGUI/Operation/User.pm
View file

@ -381,6 +381,14 @@ sub www_ajaxCreateUser {
message => "",
} );
}
# User must not already exist
if ( $session->db->quickScalar( "SELECT * FROM users WHERE username=?", [$userParam{username}] ) ) {
return createServiceResponse( $outputFormat, {
error => "WebGUI::Error::InvalidParam",
param => "username",
message => "",
} );
}
### Create user
my $user = WebGUI::User->create( $session );
@ -454,6 +462,13 @@ sub www_ajaxDeleteUser {
message => 'Cannot delete system user',
} );
}
elsif ( !WebGUI::User->validUserId( $session, $userId ) ) {
return createServiceResponse( $outputFormat, {
error => 'WebGUI::Error::InvalidParam',
param => 'userId',
message => '',
} );
}
### Delete user
my $user = WebGUI::User->new( $session, $userId );
@ -520,6 +535,14 @@ sub www_ajaxUpdateUser {
message => "",
} );
}
# User must exist
if ( !WebGUI::User->validUserId( $session, $userParam{userId} ) ) {
return createServiceResponse( $outputFormat, {
error => "WebGUI::Error::InvalidParam",
param => "userId",
message => "",
} );
}
### Update user
my $user = WebGUI::User->new( $session, delete $userParam{userId} );