remove eval{} from caching code

This commit is contained in:
Doug Bell 2010-04-19 18:39:49 -05:00
parent 841e9d5784
commit 165be5b389
22 changed files with 59 additions and 59 deletions

View file

@ -126,7 +126,7 @@ not be added to any group. Groups may not be added to themselves.
sub addGroups {
my $self = shift;
my $groups = shift;
eval{$self->session->cache->delete($self->getId)};
$self->session->cache->delete($self->getId);
GROUP: foreach my $gid (@{$groups}) {
next if ($gid eq '1');
next if ($gid eq $self->getId);
@ -233,7 +233,7 @@ sub clearCaches {
my $groups = $self->getAllGroupsFor();
my $cache = $self->session->cache;
foreach my $group ( $self->getId, @{ $groups } ) {
eval{$cache->delete($group)};
$cache->delete($group);
}
my $stow = $self->session->stow;
$stow->delete("groupObj");
@ -562,7 +562,7 @@ sub getAllUsers {
my $loopCount = shift;
my $expireTime = 0;
my $cache = $self->session->cache;
my $value = eval{$cache->get($self->getId)};
my $value = $cache->get($self->getId);
return $value if defined $value;
my @users = ();
push @users,
@ -587,7 +587,7 @@ sub getAllUsers {
}
my %users = map { $_ => 1 } @users;
@users = keys %users;
eval{$cache->set($self->getId, \@users, $self->groupCacheTimeout)};
$cache->set($self->getId, \@users, $self->groupCacheTimeout);
return \@users;
}