Fix typos in recursive Group->getAllUsers calls. Fixes bug #11566

This commit is contained in:
Colin Kuskie 2010-05-11 18:40:40 -07:00
parent 55d55b4eee
commit 18de531bc1
2 changed files with 2 additions and 2 deletions

View file

@ -13,6 +13,7 @@
- fixed #11562: Missing perl modules in gotcha
- fixed #11565: Can't clear cache on plainblack.com
- fixed #11540: Pending version tags are not completed on approval under certain conditions
- fixed #11566: Group API: group membership cannot be checked without consideration of expiration dates.
7.9.4
- We're shipping underscore.js now for its suite of extremely handy utility

View file

@ -577,12 +577,11 @@ sub getAllUsers {
$self->session->errorHandler->fatal("Endless recursive loop detected while determining groups in group.\nRequested groupId: ".$self->getId);
}
my $groups = $self->getGroupsIn();
##Have to iterate twice due to the withoutExpired clause.
foreach my $groupId (@{ $groups }) {
my $subGroup = WebGUI::Group->new($self->session, $groupId);
next
if !$subGroup;
push @users, @{ $subGroup->getAllUsers(1, $withoutExpired, $loopCount) };
push @users, @{ $subGroup->getAllUsers($withoutExpired, $loopCount) };
}
my %users = map { $_ => 1 } @users;
@users = keys %users;