oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add hex generation code to tempspace Storage objects. Otherwise, they return undef.

Browse source
This commit is contained in:
Colin Kuskie 2009-07-02 16:01:03 +00:00
parent 277701a2cc
commit 1d3d61e16f
2 changed files with 14 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/WebGUI/Storage.pm
View file

@ -617,7 +617,7 @@ sub createTemp {
my $path = $session->id->toHex($id); my $path = $session->id->toHex($id);
$path =~ m/^(.{2})/; $path =~ m/^(.{2})/;
my $self = {_session=>$session, _id => $id, _Hexid => $path, _pathParts => ['temp', $1, $path], _errors => []}; my $self = {_session=>$session, _id => $id, _hexId => $path, _pathParts => ['temp', $1, $path], _errors => []};
bless $self, ref($class)||$class; bless $self, ref($class)||$class;
$self->_makePath; $self->_makePath;
return $self; return $self;

18
t/Storage.t
View file

@ -29,7 +29,7 @@ my $cwd = Cwd::cwd();
my ($extensionTests, $fileIconTests) = setupDataDrivenTests($session); my ($extensionTests, $fileIconTests) = setupDataDrivenTests($session);
my $numTests = 103; # increment this value for each test you create my $numTests = 107; # increment this value for each test you create
plan tests => $numTests + scalar @{ $extensionTests } + scalar @{ $fileIconTests }; plan tests => $numTests + scalar @{ $extensionTests } + scalar @{ $fileIconTests };
my $uploadDir = $session->config->get('uploadsPath'); my $uploadDir = $session->config->get('uploadsPath');
@ -150,7 +150,13 @@ $storage1 = WebGUI::Storage->create($session);
isa_ok( $storage1, "WebGUI::Storage"); isa_ok( $storage1, "WebGUI::Storage");
ok($session->id->valid($storage1->getId), 'create returns valid sessionIds'); ok($session->id->valid($storage1->getId), 'create returns valid sessionIds');
is($storage1->getHexId, $session->id->toHex($storage1->getId), 'getHexId, returns the hexadecimal value of the GUID'); ok($storage1->getHexId, 'getHexId returns something');
is($storage1->getHexId, $session->id->toHex($storage1->getId), '... returns the hexadecimal value of the GUID');
{
my $otherStorage = WebGUI::Storage->get($session, $storage1->getId);
is($otherStorage->getHexId, $storage1->getHexId, '... works with get');
}
is( $storage1->getErrorCount, 0, "No errors during object creation"); is( $storage1->getErrorCount, 0, "No errors during object creation");
@ -286,15 +292,17 @@ ok(-e $hackedStore->getPath('fileToHack'), 'deleteFile did not delete the file i
#################################################### ####################################################
# #
# createTemp # createTemp, getHexId
# #
#################################################### ####################################################
my $tempStor = WebGUI::Storage->createTemp($session); my $tempStor = WebGUI::Storage->createTemp($session);
isa_ok( $tempStor, "WebGUI::Storage", "createTemp creates WebGUI::Storage object"); isa_ok( $tempStor, "WebGUI::Storage", "createTemp creates WebGUI::Storage object");
is (substr($tempStor->getPathFrag, 0, 5), 'temp/', 'createTemp puts stuff in the temp directory'); is (substr($tempStor->getPathFrag, 0, 5), 'temp/', '... puts stuff in the temp directory');
ok (-e $tempStor->getPath(), 'createTemp: directory was created'); ok (-e $tempStor->getPath(), '... directory was created');
ok($tempStor->getHexId, '... getHexId returns something');
is($tempStor->getHexId, $session->id->toHex($tempStor->getId), '... returns the hexadecimal value of the GUID');
#################################################### ####################################################
# #