From 1f305caee03493b3b2b75e0f4b32e8d7bb0b0843 Mon Sep 17 00:00:00 2001 From: "John W. Krahn" Date: Wed, 5 Feb 2003 04:19:28 +0000 Subject: [PATCH] tidy (perltidy), simplify and optimise --- lib/WebGUI/Operation/ProfileSettings.pm | 430 ++++++++++++------------ 1 file changed, 210 insertions(+), 220 deletions(-) diff --git a/lib/WebGUI/Operation/ProfileSettings.pm b/lib/WebGUI/Operation/ProfileSettings.pm index 3ee9c9e17..1d411f491 100644 --- a/lib/WebGUI/Operation/ProfileSettings.pm +++ b/lib/WebGUI/Operation/ProfileSettings.pm @@ -22,308 +22,298 @@ use WebGUI::Privilege; use WebGUI::Session; use WebGUI::SQL; -our @ISA = qw(Exporter); +our @ISA = qw(Exporter); our @EXPORT = qw(&www_deleteProfileCategoryConfirm &www_deleteProfileFieldConfirm &www_editProfileCategorySave &www_editProfileFieldSave &www_deleteProfileCategory &www_deleteProfileField &www_editProfileCategory &www_editProfileField &www_moveProfileCategoryDown &www_moveProfileCategoryUp &www_moveProfileFieldDown &www_moveProfileFieldUp &www_editProfileSettings); #------------------------------------------------------------------- sub _reorderCategories { - my ($sth, $i, $id); - $sth = WebGUI::SQL->read("select profileCategoryId from userProfileCategory order by sequenceNumber"); - while (($id) = $sth->array) { - $i++; - WebGUI::SQL->write("update userProfileCategory set sequenceNumber='$i' where profileCategoryId=$id"); - } - $sth->finish; + my $sth = WebGUI::SQL->read( 'select profileCategoryId from userProfileCategory order by sequenceNumber' ); + my $i = 1; + while ( my ( $id ) = $sth->array ) { + WebGUI::SQL->write( q[update userProfileCategory set sequenceNumber='] . $i++ . q[' where profileCategoryId=] . $id ); + } + $sth->finish; } #------------------------------------------------------------------- sub _reorderFields { - my ($sth, $i, $id); - $sth = WebGUI::SQL->read("select fieldName from userProfileField where profileCategoryId=".quote($_[0])." order by sequenceNumber"); - while (($id) = $sth->array) { - $i++; - WebGUI::SQL->write("update userProfileField set sequenceNumber='$i' where fieldName=".quote($id)); - } - $sth->finish; + my ( $sth, $i, $id ); + my $sth = WebGUI::SQL->read( 'select fieldName from userProfileField where profileCategoryId=' . quote( $_[ 0 ] ) . ' order by sequenceNumber' ); + my $i = 1; + while ( my ( $id ) = $sth->array ) { + WebGUI::SQL->write( q[update userProfileField set sequenceNumber='] . $i++ . q[' where fieldName=] . quote( $id ) ); + } + $sth->finish; } #------------------------------------------------------------------- sub _submenu { - my (%menu); - tie %menu, 'Tie::IxHash'; - $menu{WebGUI::URL::page("op=editProfileCategory")} = WebGUI::International::get(490); - $menu{WebGUI::URL::page("op=editProfileField")} = WebGUI::International::get(491); - if (($session{form}{op} eq "editProfileField" && $session{form}{fid} ne "new") || $session{form}{op} eq "deleteProfileField") { - $menu{WebGUI::URL::page('op=editProfileField&fid='.$session{form}{fid})} = WebGUI::International::get(787); - $menu{WebGUI::URL::page('op=deleteProfileField&fid='.$session{form}{fid})} = WebGUI::International::get(788); + tie my %menu, 'Tie::IxHash'; + $menu{ WebGUI::URL::page( 'op=editProfileCategory' ) } = WebGUI::International::get( 490 ); + $menu{ WebGUI::URL::page( 'op=editProfileField' ) } = WebGUI::International::get( 491 ); + if ( ( $session{ form }{ op } eq 'editProfileField' and $session{ form }{ fid } ne 'new' ) or $session{ form }{ op } eq 'deleteProfileField' ) { + $menu{ WebGUI::URL::page( 'op=editProfileField&fid=' . $session{ form }{ fid } ) } = WebGUI::International::get( 787 ); + $menu{ WebGUI::URL::page( 'op=deleteProfileField&fid=' . $session{ form }{ fid } ) } = WebGUI::International::get( 788 ); } - if (($session{form}{op} eq "editProfileCategory" && $session{form}{cid} ne "new") || $session{form}{op} eq "deleteProfileCategory") { - $menu{WebGUI::URL::page('op=editProfileCategory&cid='.$session{form}{cid})} = WebGUI::International::get(789); - $menu{WebGUI::URL::page('op=deleteProfileCategory&cid='.$session{form}{cid})} = WebGUI::International::get(790); - } - $menu{WebGUI::URL::page("op=editProfileSettings")} = WebGUI::International::get(492); - $menu{WebGUI::URL::page('op=manageSettings')} = WebGUI::International::get(4); - return menuWrapper($_[0],\%menu); + if ( ( $session{ form }{ op } eq 'editProfileCategory' and $session{ form }{ cid } ne 'new' ) or $session{ form }{ op } eq 'deleteProfileCategory' ) { + $menu{ WebGUI::URL::page( 'op=editProfileCategory&cid=' . $session{ form }{ cid } ) } = WebGUI::International::get( 789 ); + $menu{ WebGUI::URL::page( 'op=deleteProfileCategory&cid=' . $session{ form }{ cid } ) } = WebGUI::International::get( 790 ); + } + $menu{ WebGUI::URL::page( 'op=editProfileSettings' ) } = WebGUI::International::get( 492 ); + $menu{ WebGUI::URL::page( 'op=manageSettings' ) } = WebGUI::International::get( 4 ); + return menuWrapper( $_[ 0 ], \%menu ); } #------------------------------------------------------------------- sub www_deleteProfileCategory { - return WebGUI::Privilege::adminOnly() unless (WebGUI::Privilege::isInGroup(3)); - my ($output); - return WebGUI::Privilege::vitalComponent() if ($session{form}{cid} < 1000); - $output = '

'.WebGUI::International::get(42).'

'; - $output .= WebGUI::International::get(466).'

'; - $output .= '

'.WebGUI::International::get(44).''; - $output .= '    '. - WebGUI::International::get(45).'
'; - return _submenu($output); + return WebGUI::Privilege::adminOnly() unless WebGUI::Privilege::isInGroup( 3 ); + return WebGUI::Privilege::vitalComponent() if $session{ form }{ cid } < 1000; + my $output = '

' . WebGUI::International::get( 42 ) . '

' + . WebGUI::International::get( 466 ) . '

' + . '

' . WebGUI::International::get( 44 ) . '' + . '    ' + . WebGUI::International::get( 45 ) . '
'; + return _submenu( $output ); } #------------------------------------------------------------------- sub www_deleteProfileCategoryConfirm { - return WebGUI::Privilege::adminOnly() unless (WebGUI::Privilege::isInGroup(3)); - return WebGUI::Privilege::vitalComponent() if ($session{form}{cid} < 1000); - WebGUI::SQL->write("delete from userProfileCategory where profileCategoryId=$session{form}{cid}"); - WebGUI::SQL->write("update userProfileField set profileCategoryId=1 where profileCategoryId=$session{form}{cid}"); - return www_editProfileSettings(); + return WebGUI::Privilege::adminOnly() unless WebGUI::Privilege::isInGroup( 3 ); + return WebGUI::Privilege::vitalComponent() if $session{ form }{ cid } < 1000; + WebGUI::SQL->write( "delete from userProfileCategory where profileCategoryId=$session{form}{cid}" ); + WebGUI::SQL->write( "update userProfileField set profileCategoryId=1 where profileCategoryId=$session{form}{cid}" ); + return www_editProfileSettings(); } #------------------------------------------------------------------- sub www_deleteProfileField { - return WebGUI::Privilege::adminOnly() unless (WebGUI::Privilege::isInGroup(3)); - my ($output,$protected); - ($protected) = WebGUI::SQL->quickArray("select protected from userProfileField where fieldname=".quote($session{form}{fid})); - return WebGUI::Privilege::vitalComponent() if ($protected); - $output = '

'.WebGUI::International::get(42).'

'; - $output .= WebGUI::International::get(467).'

'; - $output .= '

'.WebGUI::International::get(44).''; - $output .= '    '. - WebGUI::International::get(45).'
'; - return _submenu($output); + return WebGUI::Privilege::adminOnly() unless WebGUI::Privilege::isInGroup( 3 ); + my ( $protected ) = WebGUI::SQL->quickArray( 'select protected from userProfileField where fieldname=' . quote( $session{ form }{ fid } ) ); + return WebGUI::Privilege::vitalComponent() if $protected; + my $output = '

' . WebGUI::International::get( 42 ) . '

' + . WebGUI::International::get( 467 ) . '

' + . '

' . WebGUI::International::get( 44 ) . '' + . '    ' + . WebGUI::International::get( 45 ) . '
'; + return _submenu( $output ); } #------------------------------------------------------------------- sub www_deleteProfileFieldConfirm { - return WebGUI::Privilege::adminOnly() unless (WebGUI::Privilege::isInGroup(3)); - my ($protected); - ($protected) = WebGUI::SQL->quickArray("select protected from userProfileField where fieldname=".quote($session{form}{fid})); - return WebGUI::Privilege::vitalComponent() if ($protected); - WebGUI::SQL->write("delete from userProfileField where fieldName=".quote($session{form}{fid})); - WebGUI::SQL->write("delete from userProfileData where fieldName=".quote($session{form}{fid})); - return www_editProfileSettings(); + return WebGUI::Privilege::adminOnly() unless WebGUI::Privilege::isInGroup( 3 ); + my ( $protected ) = WebGUI::SQL->quickArray( 'select protected from userProfileField where fieldname=' . quote( $session{ form }{ fid } ) ); + return WebGUI::Privilege::vitalComponent() if $protected; + WebGUI::SQL->write( 'delete from userProfileField where fieldName=' . quote( $session{ form }{ fid } ) ); + WebGUI::SQL->write( 'delete from userProfileData where fieldName=' . quote( $session{ form }{ fid } ) ); + return www_editProfileSettings(); } #------------------------------------------------------------------- sub www_editProfileCategory { - return WebGUI::Privilege::adminOnly() unless (WebGUI::Privilege::isInGroup(3)); - my ($output, $f, %data); - tie %data, 'Tie::CPHash'; - $output = '

'.WebGUI::International::get(468).'

'; - $f = WebGUI::HTMLForm->new; - $f->hidden("op","editProfileCategorySave"); - if ($session{form}{cid}) { - $f->hidden("cid",$session{form}{cid}); - $f->readOnly($session{form}{cid},WebGUI::International::get(469)); - %data = WebGUI::SQL->quickHash("select * from userProfileCategory where profileCategoryId=$session{form}{cid}"); - } else { - $f->hidden("cid","new"); + return WebGUI::Privilege::adminOnly() unless WebGUI::Privilege::isInGroup( 3 ); + + tie my %data, 'Tie::CPHash'; + my $f = WebGUI::HTMLForm->new; + $f->hidden( 'op', 'editProfileCategorySave' ); + if ( $session{ form }{ cid } ) { + $f->hidden( 'cid', $session{ form }{ cid } ); + $f->readOnly( $session{ form }{ cid }, WebGUI::International::get( 469 ) ); + %data = WebGUI::SQL->quickHash( "select * from userProfileCategory where profileCategoryId=$session{form}{cid}" ); } - $f->text("categoryName",WebGUI::International::get(470),$data{categoryName}); + else { + $f->hidden( 'cid', 'new' ); + } + $f->text( 'categoryName', WebGUI::International::get( 470 ), $data{ categoryName } ); $f->submit; - $output .= $f->print; - return _submenu($output); + + return _submenu( '

' . WebGUI::International::get( 468 ) . '

' . $f->print ); } #------------------------------------------------------------------- sub www_editProfileCategorySave { - return WebGUI::Privilege::adminOnly() unless (WebGUI::Privilege::isInGroup(3)); - my ($categoryId, $sequenceNumber, $test); - $session{form}{categoryName} = 'Unamed' if ($session{form}{categoryName} eq "" || $session{form}{categoryName} eq "''"); - $test = eval($session{form}{categoryName}); - $session{form}{categoryName} = "'".$session{form}{categoryName}."'" if ($test eq ""); - if ($session{form}{cid} eq "new") { - $categoryId = getNextId("profileCategoryId"); - ($sequenceNumber) = WebGUI::SQL->quickArray("select max(sequenceNumber) from userProfileCategory"); - WebGUI::SQL->write("insert into userProfileCategory values ($categoryId, ".quote($session{form}{categoryName}).", - ".($sequenceNumber+1).")"); - } else { - WebGUI::SQL->write("update userProfileCategory set categoryName=".quote($session{form}{categoryName})." where - profileCategoryId=$session{form}{cid}"); + return WebGUI::Privilege::adminOnly() unless WebGUI::Privilege::isInGroup( 3 ); + + $session{ form }{ categoryName } = 'Unamed' if $session{ form }{ categoryName } eq '' or $session{ form }{ categoryName } eq q['']; + my $test = eval $session{ form }{ categoryName }; + $session{ form }{ categoryName } = "'$session{form}{categoryName}'" if $test eq ''; + if ( $session{ form }{ cid } eq 'new' ) { + my $categoryId = getNextId( 'profileCategoryId' ); + my ( $sequenceNumber ) = WebGUI::SQL->quickArray( 'select max(sequenceNumber) from userProfileCategory' ); + WebGUI::SQL->write( "insert into userProfileCategory values ($categoryId, " . quote( $session{ form }{ categoryName } ) + . ', ' . $sequenceNumber + 1 . ')' ); + } + else { + WebGUI::SQL->write( 'update userProfileCategory set categoryName=' . quote( $session{ form }{ categoryName } ) + . " where profileCategoryId=$session{form}{cid}" ); } return www_editProfileSettings(); } #------------------------------------------------------------------- sub www_editProfileField { - return WebGUI::Privilege::adminOnly() unless (WebGUI::Privilege::isInGroup(3)); - my ($output, $f, %data, %hash, $key); - tie %data, 'Tie::CPHash'; - $output = '

'.WebGUI::International::get(471).'

'; - $f = WebGUI::HTMLForm->new; - $f->hidden("op","editProfileFieldSave"); - if ($session{form}{fid}) { - $f->hidden("fid",$session{form}{fid}); - $f->readOnly($session{form}{fid},WebGUI::International::get(470)); - %data = WebGUI::SQL->quickHash("select * from userProfileField where fieldName=".quote($session{form}{fid})); - } else { - $f->hidden("new",1); - $f->text("fid",WebGUI::International::get(470)); + return WebGUI::Privilege::adminOnly() unless WebGUI::Privilege::isInGroup( 3 ); + + tie my %data, 'Tie::CPHash'; + my $f = WebGUI::HTMLForm->new; + $f->hidden( 'op', 'editProfileFieldSave' ); + if ( $session{ form }{ fid } ) { + $f->hidden( 'fid', $session{ form }{ fid } ); + $f->readOnly( $session{ form }{ fid }, WebGUI::International::get( 470 ) ); + %data = WebGUI::SQL->quickHash( 'select * from userProfileField where fieldName=' . quote( $session{ form }{ fid } ) ); } - $f->text("fieldLabel",WebGUI::International::get(472),$data{fieldLabel}); - $f->yesNo("visible",WebGUI::International::get(473),$data{visible}); - $f->yesNo("required",WebGUI::International::get(474),$data{required}); - tie %hash, 'Tie::IxHash'; - %hash = ( 'text'=>WebGUI::International::get(475), - 'textarea'=>WebGUI::International::get(476), - 'HTMLArea'=>WebGUI::International::get(477), - 'url'=>WebGUI::International::get(478), - 'date'=>WebGUI::International::get(479), - 'email'=>WebGUI::International::get(480), - 'phone'=>WebGUI::International::get(481), - 'integer'=>WebGUI::International::get(482), - 'yesNo'=>WebGUI::International::get(483), - 'select'=>WebGUI::International::get(484) - ); - $f->select("dataType",\%hash,WebGUI::International::get(486),[$data{dataType}]); - $f->textarea("dataValues",WebGUI::International::get(487),$data{dataValues}); - $f->textarea("dataDefault",WebGUI::International::get(488),$data{dataDefault}); + else { + $f->hidden( 'new', 1 ); + $f->text( 'fid', WebGUI::International::get( 470 ) ); + } + $f->text( 'fieldLabel', WebGUI::International::get( 472 ), $data{ fieldLabel } ); + $f->yesNo( 'visible', WebGUI::International::get( 473 ), $data{ visible } ); + $f->yesNo( 'required', WebGUI::International::get( 474 ), $data{ required } ); + tie my %hash, 'Tie::IxHash'; + my %hash = ( + 'text' => WebGUI::International::get( 475 ), + 'textarea' => WebGUI::International::get( 476 ), + 'HTMLArea' => WebGUI::International::get( 477 ), + 'url' => WebGUI::International::get( 478 ), + 'date' => WebGUI::International::get( 479 ), + 'email' => WebGUI::International::get( 480 ), + 'phone' => WebGUI::International::get( 481 ), + 'integer' => WebGUI::International::get( 482 ), + 'yesNo' => WebGUI::International::get( 483 ), + 'select' => WebGUI::International::get( 484 ) + ); + $f->selectList( 'dataType', \%hash, WebGUI::International::get( 486 ), [ $data{ dataType } ] ); + untie %hash; + $f->textarea( 'dataValues', WebGUI::International::get( 487 ), $data{ dataValues } ); + $f->textarea( 'dataDefault', WebGUI::International::get( 488 ), $data{ dataDefault } ); tie %hash, 'Tie::CPHash'; - %hash = WebGUI::SQL->buildHash("select profileCategoryId,categoryName from userProfileCategory order by categoryName"); - foreach $key (keys %hash) { - $hash{$key} = eval $hash{$key}; + %hash = WebGUI::SQL->buildHash( 'select profileCategoryId,categoryName from userProfileCategory order by categoryName' ); + for my $key ( keys %hash ) { + $hash{ $key } = eval $hash{ $key }; } - $f->select("profileCategoryId",\%hash,WebGUI::International::get(489),[$data{profileCategoryId}]); - $f->submit; - $output .= $f->print; - return _submenu($output); + $f->select( 'profileCategoryId', \%hash, WebGUI::International::get( 489 ), [ $data{ profileCategoryId } ] ); + $f->submit; + + return _submenu( '

' . WebGUI::International::get( 471 ) . '

' . $f->print ); } #------------------------------------------------------------------- sub www_editProfileFieldSave { - return WebGUI::Privilege::adminOnly() unless (WebGUI::Privilege::isInGroup(3)); - my ($sequenceNumber, $fieldName, $test); - $session{form}{fieldLabel} = 'Unamed' if ($session{form}{fieldLabel} eq "" || $session{form}{fieldLabel} eq "''"); - $test = eval($session{form}{fieldLabel}); - $session{form}{fieldLabel} = "'".$session{form}{fieldLabel}."'" if ($test eq ""); - if ($session{form}{new}) { - ($fieldName) = WebGUI::SQL->quickArray("select count(*) from userProfileField - where fieldName=".quote($session{form}{fid})); - if ($fieldName) { - $session{form}{fid} .= '2'; - } - ($sequenceNumber) = WebGUI::SQL->quickArray("select max(sequenceNumber) - from userProfileField where profileCategoryId=$session{form}{profileCategoryId}"); - WebGUI::SQL->write("insert into userProfileField (fieldName, sequenceNumber, protected) - values (".quote($session{form}{fid}).", ".($sequenceNumber+1).", 0)"); + return WebGUI::Privilege::adminOnly() unless ( WebGUI::Privilege::isInGroup( 3 ) ); + + $session{ form }{ fieldLabel } = 'Unamed' if $session{ form }{ fieldLabel } eq '' or $session{ form }{ fieldLabel } eq q['']; + my $test = eval $session{ form }{ fieldLabel }; + $session{ form }{ fieldLabel } = "'$session{form}{fieldLabel}'" if $test eq ''; + if ( $session{ form }{ new } ) { + my ( $fieldName ) = WebGUI::SQL->quickArray( 'select count(*) from userProfileField where fieldName=' + . quote( $session{ form }{ fid } ) ); + $session{ form }{ fid } .= '2' if $fieldName; + my ( $sequenceNumber ) = WebGUI::SQL->quickArray( "select max(sequenceNumber) + from userProfileField where profileCategoryId=$session{form}{profileCategoryId}" ); + WebGUI::SQL->write( 'insert into userProfileField (fieldName, sequenceNumber, protected) values (' + . quote( $session{ form }{ fid } ) . ', ' . $sequenceNumber + 1 . ', 0)' ); } - WebGUI::SQL->write("update userProfileField set - fieldLabel=".quote($session{form}{fieldLabel}).", + WebGUI::SQL->write( 'update userProfileField set + fieldLabel=' . quote( $session{ form }{ fieldLabel } ) . ", visible='$session{form}{visible}', required='$session{form}{required}', - dataType=".quote($session{form}{dataType}).", - dataValues=".quote($session{form}{dataValues}).", - dataDefault=".quote($session{form}{dataDefault}).", - profileCategoryId=".quote($session{form}{profileCategoryId})." - where fieldName=".quote($session{form}{fid})); + dataType=" . quote( $session{ form }{ dataType } ) . ', + dataValues=' . quote( $session{ form }{ dataValues } ) . ', + dataDefault=' . quote( $session{ form }{ dataDefault } ) . ', + profileCategoryId=' . quote( $session{ form } {profileCategoryId } ) . ' + where fieldName=' . quote( $session{ form }{ fid } ) ); return www_editProfileSettings(); } #------------------------------------------------------------------- sub www_editProfileSettings { - return WebGUI::Privilege::adminOnly() unless (WebGUI::Privilege::isInGroup(3)); - my ($output, $a, %category, %field, $b); - tie %category, 'Tie::CPHash'; - tie %field, 'Tie::CPHash'; - $output = helpIcon(22); - $output .= '

'.WebGUI::International::get(308).'

'; - $a = WebGUI::SQL->read("select * from userProfileCategory order by sequenceNumber"); - while (%category = $a->hash) { - $output .= deleteIcon('op=deleteProfileCategory&cid='.$category{profileCategoryId}); - $output .= editIcon('op=editProfileCategory&cid='.$category{profileCategoryId}); - $output .= moveUpIcon('op=moveProfileCategoryUp&cid='.$category{profileCategoryId}); - $output .= moveDownIcon('op=moveProfileCategoryDown&cid='.$category{profileCategoryId}); - $output .= ' '; - $output .= eval $category{categoryName}; - $output .= '
'; - $b = WebGUI::SQL->read("select * from userProfileField where - profileCategoryId=$category{profileCategoryId} order by sequenceNumber"); - while (%field = $b->hash) { - $output .= '     '; - $output .= deleteIcon('op=deleteProfileField&fid='.$field{fieldName}); - $output .= editIcon('op=editProfileField&fid='.$field{fieldName}); - $output .= moveUpIcon('op=moveProfileFieldUp&fid='.$field{fieldName}); - $output .= moveDownIcon('op=moveProfileFieldDown&fid='.$field{fieldName}); - $output .= ' '; - $output .= eval $field{fieldLabel}; - $output .= '
'; + return WebGUI::Privilege::adminOnly() unless ( WebGUI::Privilege::isInGroup( 3 ) ); + + my $output = helpIcon( 22 ) + . '

' . WebGUI::International::get( 308 ) . '

'; + my $a = WebGUI::SQL->read( 'select * from userProfileCategory order by sequenceNumber' ); + + tie my %category, 'Tie::CPHash'; + while ( %category = $a->hash ) { + $output .= deleteIcon( 'op=deleteProfileCategory&cid=' . $category{ profileCategoryId } ) + . editIcon( 'op=editProfileCategory&cid=' . $category{ profileCategoryId } ) + . moveUpIcon( 'op=moveProfileCategoryUp&cid=' . $category{ profileCategoryId } ) + . moveDownIcon( 'op=moveProfileCategoryDown&cid=' . $category{ profileCategoryId } ) + . ' ' + . eval $category{ categoryName } + . '
'; + my $b = WebGUI::SQL->read( "select * from userProfileField where + profileCategoryId=$category{profileCategoryId} order by sequenceNumber" ); + tie my %field, 'Tie::CPHash'; + while ( %field = $b->hash ) { + $output .= ' ' x 5 + . deleteIcon( 'op=deleteProfileField&fid=' . $field{ fieldName } ) + . editIcon( 'op=editProfileField&fid=' . $field{ fieldName } ) + . moveUpIcon( 'op=moveProfileFieldUp&fid=' . $field{ fieldName } ) + . moveDownIcon( 'op=moveProfileFieldDown&fid=' . $field{ fieldName } ) + . ' ' + . eval $field{ fieldLabel } + . '
'; } $b->finish; } $a->finish; - return _submenu($output); + return _submenu( $output ); } #------------------------------------------------------------------- sub www_moveProfileCategoryDown { - return WebGUI::Privilege::adminOnly() unless (WebGUI::Privilege::isInGroup(3)); - my ($id, $thisSeq); - ($thisSeq) = WebGUI::SQL->quickArray("select sequenceNumber from userProfileCategory where profileCategoryId=$session{form}{cid}"); - ($id) = WebGUI::SQL->quickArray("select profileCategoryId from userProfileCategory where sequenceNumber=$thisSeq+1"); - if ($id ne "") { - WebGUI::SQL->write("update userProfileCategory set sequenceNumber=sequenceNumber+1 where profileCategoryId=$session{form}{cid}"); - WebGUI::SQL->write("update userProfileCategory set sequenceNumber=sequenceNumber-1 where profileCategoryId=$id"); - _reorderCategories(); - } - return www_editProfileSettings(); + return WebGUI::Privilege::adminOnly() unless WebGUI::Privilege::isInGroup( 3 ); + my ( $thisSeq ) = WebGUI::SQL->quickArray( "select sequenceNumber from userProfileCategory where profileCategoryId=$session{form}{cid}" ); + my ( $id ) = WebGUI::SQL->quickArray( "select profileCategoryId from userProfileCategory where sequenceNumber=$thisSeq+1" ); + if ( $id ne '' ) { + WebGUI::SQL->write( "update userProfileCategory set sequenceNumber=sequenceNumber+1 where profileCategoryId=$session{form}{cid}" ); + WebGUI::SQL->write( "update userProfileCategory set sequenceNumber=sequenceNumber-1 where profileCategoryId=$id" ); + _reorderCategories(); + } + return www_editProfileSettings(); } #------------------------------------------------------------------- sub www_moveProfileCategoryUp { - return WebGUI::Privilege::adminOnly() unless (WebGUI::Privilege::isInGroup(3)); - my ($id, $thisSeq); - ($thisSeq) = WebGUI::SQL->quickArray("select sequenceNumber from userProfileCategory where profileCategoryId=$session{form}{cid}"); - ($id) = WebGUI::SQL->quickArray("select profileCategoryId from userProfileCategory where sequenceNumber=$thisSeq-1"); - if ($id ne "") { - WebGUI::SQL->write("update userProfileCategory set sequenceNumber=sequenceNumber-1 where profileCategoryId=$session{form}{cid}"); - WebGUI::SQL->write("update userProfileCategory set sequenceNumber=sequenceNumber+1 where profileCategoryId=$id"); - _reorderCategories(); - } - return www_editProfileSettings(); + return WebGUI::Privilege::adminOnly() unless WebGUI::Privilege::isInGroup( 3 ); + my ( $thisSeq ) = WebGUI::SQL->quickArray( "select sequenceNumber from userProfileCategory where profileCategoryId=$session{form}{cid}" ); + my ( $id ) = WebGUI::SQL->quickArray( "select profileCategoryId from userProfileCategory where sequenceNumber=$thisSeq-1" ); + if ( $id ne '' ) { + WebGUI::SQL->write( "update userProfileCategory set sequenceNumber=sequenceNumber-1 where profileCategoryId=$session{form}{cid}" ); + WebGUI::SQL->write( "update userProfileCategory set sequenceNumber=sequenceNumber+1 where profileCategoryId=$id" ); + _reorderCategories(); + } + return www_editProfileSettings(); } #------------------------------------------------------------------- sub www_moveProfileFieldDown { - return WebGUI::Privilege::adminOnly() unless (WebGUI::Privilege::isInGroup(3)); - my ($id, $thisSeq, $profileCategoryId); - ($thisSeq,$profileCategoryId) = WebGUI::SQL->quickArray("select sequenceNumber,profileCategoryId from userProfileField where fieldName=".quote($session{form}{fid})); - ($id) = WebGUI::SQL->quickArray("select fieldName from userProfileField where profileCategoryId=$profileCategoryId and sequenceNumber=$thisSeq+1"); - if ($id ne "") { - WebGUI::SQL->write("update userProfileField set sequenceNumber=sequenceNumber+1 where fieldName=".quote($session{form}{fid})); - WebGUI::SQL->write("update userProfileField set sequenceNumber=sequenceNumber-1 where fieldName=".quote($id)); - _reorderFields($profileCategoryId); - } - return www_editProfileSettings(); + return WebGUI::Privilege::adminOnly() unless WebGUI::Privilege::isInGroup( 3 ); + my ( $thisSeq, $profileCategoryId ) = WebGUI::SQL->quickArray( 'select sequenceNumber,profileCategoryId from userProfileField where fieldName=' . quote( $session{ form }{ fid } ) ); + my ( $id ) = WebGUI::SQL->quickArray( "select fieldName from userProfileField where profileCategoryId=$profileCategoryId and sequenceNumber=$thisSeq+1" ); + if ( $id ne '' ) { + WebGUI::SQL->write( 'update userProfileField set sequenceNumber=sequenceNumber+1 where fieldName=' . quote( $session{ form }{ fid } ) ); + WebGUI::SQL->write( 'update userProfileField set sequenceNumber=sequenceNumber-1 where fieldName=' . quote( $id ) ); + _reorderFields( $profileCategoryId ); + } + return www_editProfileSettings(); } #------------------------------------------------------------------- sub www_moveProfileFieldUp { - return WebGUI::Privilege::adminOnly() unless (WebGUI::Privilege::isInGroup(3)); - my ($id, $thisSeq, $profileCategoryId); - ($thisSeq,$profileCategoryId) = WebGUI::SQL->quickArray("select sequenceNumber,profileCategoryId from userProfileField where fieldName=".quote($session{form}{fid})); - ($id) = WebGUI::SQL->quickArray("select fieldName from userProfileField where profileCategoryId=$profileCategoryId and sequenceNumber=$thisSeq-1"); - if ($id ne "") { - WebGUI::SQL->write("update userProfileField set sequenceNumber=sequenceNumber-1 where fieldName=".quote($session{form}{fid})); - WebGUI::SQL->write("update userProfileField set sequenceNumber=sequenceNumber+1 where fieldName=".quote($id)); - _reorderFields($profileCategoryId); - } - return www_editProfileSettings(); + return WebGUI::Privilege::adminOnly() unless WebGUI::Privilege::isInGroup( 3 ); + my ( $thisSeq, $profileCategoryId ) = WebGUI::SQL->quickArray( 'select sequenceNumber,profileCategoryId from userProfileField where fieldName=' . quote( $session{ form }{ fid } ) ); + my ( $id ) = WebGUI::SQL->quickArray( "select fieldName from userProfileField where profileCategoryId=$profileCategoryId and sequenceNumber=$thisSeq-1" ); + if ( $id ne '' ) { + WebGUI::SQL->write( 'update userProfileField set sequenceNumber=sequenceNumber-1 where fieldName=' . quote( $session{ form }{ fid } ) ); + WebGUI::SQL->write( 'update userProfileField set sequenceNumber=sequenceNumber+1 where fieldName=' . quote( $id ) ); + _reorderFields( $profileCategoryId ); + } + return www_editProfileSettings(); } - - - 1;