From 1f42a0a24ea8ad589441ef732812696d9482885d Mon Sep 17 00:00:00 2001 From: Colin Kuskie Date: Fri, 24 Sep 2010 08:02:17 -0700 Subject: [PATCH] Remove types for setScript calls, add setCss, which is shorthand for setLink with the CSS specific params preset. --- lib/WebGUI/Admin.pm | 20 ++++++++-------- lib/WebGUI/Asset.pm | 6 ++--- lib/WebGUI/Asset/File/Image.pm | 20 ++++++++-------- lib/WebGUI/Asset/MatrixListing.pm | 3 +-- lib/WebGUI/Asset/Shortcut.pm | 2 +- lib/WebGUI/Asset/Wobject/Carousel.pm | 2 +- lib/WebGUI/Asset/Wobject/DataForm.pm | 2 +- .../Asset/Wobject/EventManagementSystem.pm | 2 +- lib/WebGUI/Asset/Wobject/Layout.pm | 2 +- lib/WebGUI/Asset/Wobject/Map.pm | 4 ++-- lib/WebGUI/Asset/Wobject/Matrix.pm | 9 ++++--- lib/WebGUI/Asset/Wobject/Navigation.pm | 4 ++-- lib/WebGUI/Asset/Wobject/ProjectManager.pm | 18 +++----------- lib/WebGUI/Asset/Wobject/Thingy.pm | 2 +- lib/WebGUI/AssetClipboard.pm | 2 +- lib/WebGUI/AssetHelper/EditBranch.pm | 2 +- lib/WebGUI/AssetHelper/ExportHtml.pm | 2 +- lib/WebGUI/AssetTrash.pm | 2 +- lib/WebGUI/Content/AssetHistory.pm | 6 ++--- lib/WebGUI/Content/AssetManager.pm | 10 ++++---- lib/WebGUI/Form/AssetReportQuery.pm | 2 +- lib/WebGUI/Form/Attachments.pm | 2 +- lib/WebGUI/Form/Codearea.pm | 8 +++---- lib/WebGUI/Form/Color.pm | 24 +++++++++---------- lib/WebGUI/Form/DataTable.pm | 17 ++++--------- lib/WebGUI/Form/Date.pm | 18 +++++++------- lib/WebGUI/Form/DateTime.pm | 2 +- lib/WebGUI/Form/File.pm | 4 ++-- lib/WebGUI/Form/Float.pm | 2 +- lib/WebGUI/Form/HTMLArea.pm | 6 ++--- lib/WebGUI/Form/Hexadecimal.pm | 2 +- lib/WebGUI/Form/Integer.pm | 2 +- lib/WebGUI/Form/JsonTable.pm | 15 +++--------- lib/WebGUI/Form/Keywords.pm | 8 +++---- lib/WebGUI/Form/Textarea.pm | 2 +- lib/WebGUI/Form/TimeField.pm | 2 +- lib/WebGUI/Form/Url.pm | 2 +- lib/WebGUI/Form/Username.pm | 13 +++++----- lib/WebGUI/FormBuilder.pm | 2 +- lib/WebGUI/FormBuilder/Tabset.pm | 2 +- lib/WebGUI/HTMLForm.pm | 4 ++-- lib/WebGUI/Macro/AdminBar.pm | 2 +- lib/WebGUI/Macro/Widget.pm | 6 +---- lib/WebGUI/Operation/Help.pm | 2 +- lib/WebGUI/Session/Style.pm | 21 ++++++++++++++++ lib/WebGUI/Shop/TaxDriver/EU.pm | 14 +++++------ lib/WebGUI/Shop/TaxDriver/Generic.pm | 6 ++--- lib/WebGUI/Shop/Transaction.pm | 6 ++--- lib/WebGUI/Shop/Vendor.pm | 6 ++--- lib/WebGUI/TabForm.pm | 10 ++++---- 50 files changed, 159 insertions(+), 173 deletions(-) diff --git a/lib/WebGUI/Admin.pm b/lib/WebGUI/Admin.pm index 955720e85..f6981dbb7 100644 --- a/lib/WebGUI/Admin.pm +++ b/lib/WebGUI/Admin.pm @@ -517,16 +517,16 @@ sub www_view { $var->{homeUrl} = WebGUI::Asset->getDefault( $session )->getUrl; # All this needs to be template attachments - $style->setLink( $url->extras('yui/build/button/assets/skins/sam/button.css'), {type=>"text/css",rel=>"stylesheet"}); - $style->setLink( $url->extras('yui/build/menu/assets/skins/sam/menu.css'), {type=>"text/css",rel=>"stylesheet"}); - $style->setLink( $url->extras('yui/build/tabview/assets/skins/sam/tabview.css'), {type=>"text/css",rel=>"stylesheet"}); - $style->setLink( $url->extras('yui/build/paginator/assets/skins/sam/paginator.css'), {rel=>'stylesheet', type=>'text/css'}); - $style->setLink( $url->extras('yui/build/datatable/assets/skins/sam/datatable.css'), {rel=>'stylesheet', type=>'text/css'}); - $style->setLink( $url->extras('yui/build/container/assets/skins/sam/container.css'), {rel=>'stylesheet', type=>'text/css'}); - $style->setLink( $url->extras('yui/build/autocomplete/assets/skins/sam/autocomplete.css'), {rel=>'stylesheet', type=>'text/css'}); - $style->setLink( $url->extras('yui/build/menu/assets/skins/sam/menu.css'), {rel=>'stylesheet', type=>'text/css'}); - #$style->setLink( $url->extras('yui-webgui/build/assetManager/assetManager.css' ), { rel => "stylesheet", type => 'text/css' } ); - $style->setLink( $url->extras('admin/admin.css'), { type=>'text/css', rel=>'stylesheet'} ); + $style->setCss( $url->extras('yui/build/button/assets/skins/sam/button.css')); + $style->setCss( $url->extras('yui/build/menu/assets/skins/sam/menu.css')); + $style->setCss( $url->extras('yui/build/tabview/assets/skins/sam/tabview.css')); + $style->setCss( $url->extras('yui/build/paginator/assets/skins/sam/paginator.css')); + $style->setCss( $url->extras('yui/build/datatable/assets/skins/sam/datatable.css')); + $style->setCss( $url->extras('yui/build/container/assets/skins/sam/container.css')); + $style->setCss( $url->extras('yui/build/autocomplete/assets/skins/sam/autocomplete.css')); + $style->setCss( $url->extras('yui/build/menu/assets/skins/sam/menu.css')); + #$style->setCss( $url->extras('yui-webgui/build/assetManager/assetManager.css' )); + $style->setCss( $url->extras('admin/admin.css')); $style->setScript($url->extras('yui/build/yahoo-dom-event/yahoo-dom-event.js')); $style->setScript($url->extras('yui/build/utilities/utilities.js')); $style->setScript($url->extras('yui/build/element/element-min.js')); diff --git a/lib/WebGUI/Asset.pm b/lib/WebGUI/Asset.pm index 074f31129..1dfb10e09 100644 --- a/lib/WebGUI/Asset.pm +++ b/lib/WebGUI/Asset.pm @@ -1577,8 +1577,8 @@ sub getToolbar { $toolbar .= $self->session->icon->shortcut('func=createShortcut',$self->get("url")) if ($userUiLevel >= $uiLevels->{"shortcut"} && !$self->isa('WebGUI::Asset::Shortcut')); - $self->session->style->setLink($self->session->url->extras('assetToolbar/assetToolbar.css'), {rel=>"stylesheet",type=>"text/css"}); - $self->session->style->setLink($self->session->url->extras('yui/build/menu/assets/skins/sam/menu.css'), {rel=>"stylesheet",type=>"text/css"}); + $self->session->style->setCss($self->session->url->extras('assetToolbar/assetToolbar.css')); + $self->session->style->setCss($self->session->url->extras('yui/build/menu/assets/skins/sam/menu.css')); $self->session->style->setScript($self->session->url->extras('yui/build/yahoo-dom-event/yahoo-dom-event.js')); $self->session->style->setScript($self->session->url->extras('yui/build/container/container_core-min.js')); $self->session->style->setScript($self->session->url->extras('yui/build/menu/menu-min.js')); @@ -2709,7 +2709,7 @@ sub www_edit { } # TODO: Make this whole thing a template instead! - $style->setLink($url->extras('yui/build/button/assets/skins/sam/button.css'),{rel => 'stylesheet', type => 'text/css' }); + $style->setCss($url->extras('yui/build/button/assets/skins/sam/button.css')); $style->setScript($url->extras('yui/build/yahoo-dom-event/yahoo-dom-event.js')); $style->setScript($url->extras('yui/build/element/element-min.js')); $style->setScript($url->extras('yui/build/button/button-min.js')); diff --git a/lib/WebGUI/Asset/File/Image.pm b/lib/WebGUI/Asset/File/Image.pm index 753dd0441..38613c581 100644 --- a/lib/WebGUI/Asset/File/Image.pm +++ b/lib/WebGUI/Asset/File/Image.pm @@ -220,8 +220,8 @@ sub view { if ($crop_js) { my ($style, $url) = $session->quick(qw(style url)); - $style->setLink($url->extras('yui/build/fonts/fonts-min.css'), {rel=>'stylesheet', type=>'text/css'}); - $style->setLink($url->extras('yui/container/assets/container.css'), {rel=>'stylesheet', type=>'text/css'}); + $style->setCss($url->extras('yui/build/fonts/fonts-min.css')); + $style->setCss($url->extras('yui/container/assets/container.css')); $style->setScript($url->extras('yui/build/yahoo-dom-event/yahoo-dom-event.js')); $style->setScript($url->extras('yui/build/container/container-min.js')); } @@ -332,9 +332,9 @@ sub www_annotate { my ($style, $url) = $session->quick(qw(style url)); - $style->setLink($url->extras('yui/build/resize/assets/skins/sam/resize.css'), {rel=>'stylesheet', type=>'text/css'}); - $style->setLink($url->extras('yui/build/fonts/fonts-min.css'), {rel=>'stylesheet', type=>'text/css'}); - $style->setLink($url->extras('yui/build/imagecropper/assets/skins/sam/imagecropper.css'), {rel=>'stylesheet', type=>'text/css'}); + $style->setCss($url->extras('yui/build/resize/assets/skins/sam/resize.css')); + $style->setCss($url->extras('yui/build/fonts/fonts-min.css')); + $style->setCss($url->extras('yui/build/imagecropper/assets/skins/sam/imagecropper.css')); $style->setScript($url->extras('yui/build/yahoo-dom-event/yahoo-dom-event.js')); $style->setScript($url->extras('yui/build/element/element-min.js')); @@ -613,8 +613,8 @@ sub www_resize { ##YUI specific datatable CSS my ($style, $url) = $session->quick(qw(style url)); - $style->setLink($url->extras('yui/build/fonts/fonts-min.css'), {rel=>'stylesheet', type=>'text/css'}); - $style->setLink($url->extras('yui/build/resize/assets/skins/sam/resize.css'), {rel=>'stylesheet', type=>'text/css'}); + $style->setCss($url->extras('yui/build/fonts/fonts-min.css')); + $style->setCss($url->extras('yui/build/resize/assets/skins/sam/resize.css')); $style->setScript($url->extras('yui/build/yahoo-dom-event/yahoo-dom-event.js')); $style->setScript($url->extras('yui/build/element/element-min.js')); $style->setScript($url->extras('yui/build/dragdrop/dragdrop-min.js')); @@ -753,9 +753,9 @@ sub www_crop { ); - $style->setLink($url->extras('yui/build/resize/assets/skins/sam/resize.css'), {rel=>'stylesheet', type=>'text/css'}); - $style->setLink($url->extras('yui/build/fonts/fonts-min.css'), {rel=>'stylesheet', type=>'text/css'}); - $style->setLink($url->extras('yui/build/imagecropper/assets/skins/sam/imagecropper.css'), {rel=>'stylesheet', type=>'text/css'}); + $style->setCss($url->extras('yui/build/resize/assets/skins/sam/resize.css')); + $style->setCss($url->extras('yui/build/fonts/fonts-min.css')); + $style->setCss($url->extras('yui/build/imagecropper/assets/skins/sam/imagecropper.css')); $style->setScript($url->extras('yui/build/yahoo-dom-event/yahoo-dom-event.js')); $style->setScript($url->extras('yui/build/element/element-min.js')); $style->setScript($url->extras('yui/build/dragdrop/dragdrop-min.js')); diff --git a/lib/WebGUI/Asset/MatrixListing.pm b/lib/WebGUI/Asset/MatrixListing.pm index 3dc33cc7d..28fde9fbf 100644 --- a/lib/WebGUI/Asset/MatrixListing.pm +++ b/lib/WebGUI/Asset/MatrixListing.pm @@ -626,8 +626,7 @@ sub view { $self->session->style->setScript($self->session->url->extras('yui/build/datatable/datatable-min.js')); $self->session->style->setScript($self->session->url->extras('yui/build/button/button-min.js')); $self->session->style->setScript($self->session->url->extras('yui/build/json/json-min.js')); - $self->session->style->setLink($self->session->url->extras('yui/build/datatable/assets/skins/sam/datatable.css'), - {type =>'text/css', rel=>'stylesheet'}); + $self->session->style->setCss($self->session->url->extras('yui/build/datatable/assets/skins/sam/datatable.css')); # Attributes diff --git a/lib/WebGUI/Asset/Shortcut.pm b/lib/WebGUI/Asset/Shortcut.pm index a91ac79a3..669300ca0 100644 --- a/lib/WebGUI/Asset/Shortcut.pm +++ b/lib/WebGUI/Asset/Shortcut.pm @@ -123,7 +123,7 @@ sub _drawQueryBuilder { # html $session->style->setScript($session->url->extras('wobject/Shortcut/querybuilder.js')); - $session->style->setLink($session->url->extras('wobject/Shortcut/querybuilder.css'), {type=>"text/css", rel=>"stylesheet"}); + $session->style->setCss($session->url->extras('wobject/Shortcut/querybuilder.css')); my $output; $output .= qq||; diff --git a/lib/WebGUI/Asset/Wobject/Carousel.pm b/lib/WebGUI/Asset/Wobject/Carousel.pm index 420476c0e..e4c875447 100644 --- a/lib/WebGUI/Asset/Wobject/Carousel.pm +++ b/lib/WebGUI/Asset/Wobject/Carousel.pm @@ -64,7 +64,7 @@ override getEditForm => sub { my $i18n = WebGUI::International->new($self->session, "Asset_Carousel"); $self->session->style->setScript($self->session->url->extras('yui/build/editor/editor-min.js')); - $self->session->style->setLink($self->session->url->extras('yui/build/editor/assets/skins/sam/editor.css'), {type =>'text/css', rel=>'stylesheet'}); + $self->session->style->setCss($self->session->url->extras('yui/build/editor/assets/skins/sam/editor.css')); $self->session->style->setScript($self->session->url->extras('wobject/Carousel/carousel.js')); my $tableRowStart = diff --git a/lib/WebGUI/Asset/Wobject/DataForm.pm b/lib/WebGUI/Asset/Wobject/DataForm.pm index eb7807dcd..048cb2bf6 100644 --- a/lib/WebGUI/Asset/Wobject/DataForm.pm +++ b/lib/WebGUI/Asset/Wobject/DataForm.pm @@ -1289,7 +1289,7 @@ Prepare the template for the form mode of the template. sub prepareViewForm { my $self = shift; - $self->session->style->setLink($self->session->url->extras('tabs/tabs.css'), {"type"=>"text/css"}); + $self->session->style->setCss($self->session->url->extras('tabs/tabs.css')); $self->session->style->setScript($self->session->url->extras('tabs/tabs.js')); my $templateId = $self->templateId; my $template = WebGUI::Asset::Template->newById($self->session, $templateId); diff --git a/lib/WebGUI/Asset/Wobject/EventManagementSystem.pm b/lib/WebGUI/Asset/Wobject/EventManagementSystem.pm index fe41ba1c4..25aacfea2 100644 --- a/lib/WebGUI/Asset/Wobject/EventManagementSystem.pm +++ b/lib/WebGUI/Asset/Wobject/EventManagementSystem.pm @@ -2443,7 +2443,7 @@ sub www_manageRegistrant { |; # render - $session->style->setLink($session->url->extras('/yui/build/reset-fonts-grids/reset-fonts-grids.css'), {rel=>"stylesheet", type=>"text/css"}); + $session->style->setCss($session->url->extras('/yui/build/reset-fonts-grids/reset-fonts-grids.css')); $session->style->setRawHeadTags(q|
$shortcutCriteriaField
$conjunctionField