diff --git a/lib/WebGUI/Asset/Shortcut.pm b/lib/WebGUI/Asset/Shortcut.pm index a91eaeaf8..892656428 100644 --- a/lib/WebGUI/Asset/Shortcut.pm +++ b/lib/WebGUI/Asset/Shortcut.pm @@ -330,31 +330,7 @@ sub getEditForm { ); } $tabform->addTab('overrides','Overrides'); - my $output = 'Add Override

'; - my %overrides = $self->getOverrides; - $output .= ''; - $output .= ''; - foreach my $definition (@{$self->definition}) { - foreach my $prop (keys %{$definition->{properties}}) { - next if $definition->{properties}{$prop}{fieldType} eq 'hidden'; - $output .= ''; - $output .= ''; - $output .= ''; - } - } - $output .= '
fieldNameEdit/DeleteOriginal ValueNew ValueReplacement value
'.$prop.''; - $output .= editIcon('func=editOverride;fieldName='.$prop,$self->getUrl()); - $output .= deleteIcon('func=deleteOverride;fieldName='.$prop,$self->getUrl()) if exists $overrides{overrides}{$prop}; - $output .= ''; - $output .= $overrides{overrides}{$prop}{origValue}; - $output .= ''; - $output .= $overrides{overrides}{$prop}{newValue}; - $output .= ''; - $output .= $overrides{overrides}{$prop}{parsedValue}; - $output .= '
'; - - - $tabform->getTab('overrides')->raw($output); + $tabform->getTab('overrides')->raw($self->getOverridesList); return $tabform; } @@ -401,27 +377,28 @@ sub getFieldsList { #------------------------------------------------------------------- sub getOverridesList { my $self = shift; - my $output = 'Add '.$self->_isUserPref('name').'

'; - my @fielden; - if ($self->_isUserPref) { - @fielden = $self->getUserPrefs; - } else { - @fielden = $self->getOverrides; - } - return $output unless scalar @fielden > 0; + my $output = 'Add Override

'; + my %overrides = $self->getOverrides; $output .= ''; - $output .= ''; - foreach my $field (@fielden) { - $output .= ''; - $output .= ''; - $output .= ''; - $output .= ''; + $output .= ''; + foreach my $definition (@{$self->getShortcutOriginal->definition}) { + foreach my $prop (keys %{$definition->{properties}}) { + next if $definition->{properties}{$prop}{fieldType} eq 'hidden'; + $output .= ''; + $output .= ''; + $output .= ''; + } } $output .= '
fieldNameEdit/Delete
'.$field->get("fieldName").''; - $output .= editIcon('func=edit',$field->getUrl()); - $output .= deleteIcon('func=delete',$field->getUrl()); - $output .= '
fieldNameEdit/DeleteOriginal ValueNew ValueReplacement value
'.$prop.''; + $output .= editIcon('func=editOverride;fieldName='.$prop,$self->getUrl()); + $output .= deleteIcon('func=deleteOverride;fieldName='.$prop,$self->getUrl()) if exists $overrides{overrides}{$prop}; + $output .= ''; + $output .= $overrides{overrides}{$prop}{origValue}; + $output .= ''; + $output .= $overrides{overrides}{$prop}{newValue}; + $output .= ''; + $output .= $overrides{overrides}{$prop}{parsedValue}; + $output .= '
'; - return $output; }