oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add tests for WebGUI::Storage::Image, and give its getThumbnailUrl method

Browse source 
some error handling.
This commit is contained in:
Colin Kuskie 2007-07-24 03:40:57 +00:00
parent 07cb430be4
commit 226dd2cf21
2 changed files with 23 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
lib/WebGUI/Storage/Image.pm
View file

@ -235,6 +235,14 @@ The file to retrieve the thumbnail for.
sub getThumbnailUrl { sub getThumbnailUrl {
my $self = shift; my $self = shift;
my $filename = shift; my $filename = shift;
if (! defined $filename) {
$self->session->errorHandler->error("Can't make a thumbnail url without a filename.");
return '';
}
if (! isIn($filename, @{ $self->getFiles() })) {
$self->session->errorHandler->error("Can't make a thumbnail for a file that is not in my storage location.");
return '';
}
return $self->getUrl("thumb-".$filename); return $self->getUrl("thumb-".$filename);
} }

17
t/Storage/Image.t
View file

@ -65,7 +65,7 @@ my $extensionTests = [
}, },
]; ];
plan tests => 36 + scalar @{ $extensionTests }; # increment this value for each test you create plan tests => 40 + scalar @{ $extensionTests }; # increment this value for each test you create
my $session = WebGUI::Test->session; my $session = WebGUI::Test->session;
@ -184,9 +184,22 @@ ok(!-e $imageCopy->getPath('thumb-square.png'), 'deleteFile also deleted the thu
is($imageCopy->deleteFile('../../'), undef, 'deleteFile in Storage::Image also returns undef if you try to delete a file outside of this storage object'); is($imageCopy->deleteFile('../../'), undef, 'deleteFile in Storage::Image also returns undef if you try to delete a file outside of this storage object');
####################################################
#
# getThumbnailUrl
#
####################################################
is($thumbStore->getThumbnailUrl(), '', 'getThumbnailUrl returns undef if no file is sent');
is($WebGUI::Test::logger_error, q/Can't make a thumbnail url without a filename./, 'getThumbnailUrl logs an error message for not sending a filename');
is($thumbStore->getThumbnailUrl('round.png'), '', 'getThumbnailUrl returns undef if the requested file is not in the storage location');
is($WebGUI::Test::logger_error, q/Can't make a thumbnail for a file that is not in my storage location./, 'getThumbnailUrl logs an error message for not sending a filename');
is($thumbStore->getThumbnailUrl('square.png'), $thumbStore->getUrl('thumb-square.png'), 'getThumbnailUrl returns the correct url');
TODO: { TODO: {
local $TODO = "Methods that need to be tested"; local $TODO = "Methods that need to be tested";
ok(0, 'getThumbnailUrl');
ok(0, 'resize'); ok(0, 'resize');
} }