oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix POD, remove dead code, use correct TTL in SendNewsletters.

Browse source
This commit is contained in:
Colin Kuskie 2009-09-11 13:08:47 -07:00
parent 785523f0b0
commit 229aaaa270
1 changed files with 4 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

14
lib/WebGUI/Workflow/Activity/SendNewsletters.pm
View file

@ -22,15 +22,11 @@ use WebGUI::Mail::Send;
=head1 NAME =head1 NAME
Package WebGUI::Workflow::Activity::Skeleton Package WebGUI::Workflow::Activity::SendNewsletters
=head1 DESCRIPTION =head1 DESCRIPTION
Tell a little about what this activity does. Process subscription requests from all Newsletters and send emails.
=head1 SYNOPSIS
See WebGUI::Workflow::Activity for details on how to use any activity.
=head1 METHODS =head1 METHODS
@ -62,7 +58,7 @@ sub definition {
#------------------------------------------------------------------- #-------------------------------------------------------------------
=head2 execute ( [ object ] ) =head2 execute ( )
See WebGUI::Workflow::Activity::execute() for details. See WebGUI::Workflow::Activity::execute() for details.
@ -70,8 +66,6 @@ See WebGUI::Workflow::Activity::execute() for details.
sub execute { sub execute {
my $self = shift; my $self = shift;
my $object = shift;
my $instance = shift;
my ($db,$eh) = $self->session->quick(qw(db errorHandler)); my ($db,$eh) = $self->session->quick(qw(db errorHandler));
my $time = time(); my $time = time();
@ -195,7 +189,7 @@ sub execute {
$db->write("update Newsletter_subscriptions set lastTimeSent = ?", [time()]); $db->write("update Newsletter_subscriptions set lastTimeSent = ?", [time()]);
# timeout if we're taking too long # timeout if we're taking too long
if (time() - $time > 50) { if (time() - $time > $self->getTTL ) {
$eh->info("Oops. Ran out of time. Will continue building newsletters in a bit."); $eh->info("Oops. Ran out of time. Will continue building newsletters in a bit.");
$subscriptionResultSet->finish; $subscriptionResultSet->finish;
return $self->WAITING(1); return $self->WAITING(1);