From 22c2102e5aec8c2835547fa63475285d2378e6f9 Mon Sep 17 00:00:00 2001 From: Colin Kuskie Date: Thu, 29 Jun 2006 04:40:33 +0000 Subject: [PATCH] fixed a bug where userId was not checked unless explicitly passed into canView --- lib/WebGUI/Asset.pm | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/lib/WebGUI/Asset.pm b/lib/WebGUI/Asset.pm index 0c8d5720b..cc362325c 100644 --- a/lib/WebGUI/Asset.pm +++ b/lib/WebGUI/Asset.pm @@ -152,10 +152,16 @@ Unique hash identifier for a user. If not specified, uses current userId. sub canView { my $self = shift; - my $userId = shift; - my $user = $self->session->user; - $user = WebGUI::User->new($self->session, $userId) if (defined $userId); my $eh = $self->session->errorHandler; + my $userId = shift; + my $user; + if (defined $userId) { + $user = WebGUI::User->new($self->session, $userId); + } + else { + $user = $self->session->user; + $userId = $user->userId(); + } if ($userId eq $self->get("ownerUserId")) { return 1; } elsif ($user->isInGroup($self->get("groupIdView"))) {