oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Update POD for several methods.

Browse source 
Make getObject clone data for safety and update tests.
Make newObject always alter $address for consistency and update tests.
This commit is contained in:
Colin Kuskie 2008-12-01 17:39:34 +00:00
parent e085eff6af
commit 23f8e48f6d
3 changed files with 51 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

13
t/Asset/Sku/ProductCollateral.t
View file

@ -291,10 +291,23 @@ is( $product5->getCollateral('variantsJSON', 'vid', $newVid)->{check}, 'no leaks
$product5->purge;
my $product6 = $root->addChild({
className => "WebGUI::Asset::Sku::Product",
title => "Wide character attempt",
});
$newVid = $product6->setCollateral('variantsJSON', 'vid', 'new', { wideChar => q!“I hope this has a smart quote in it.”!
, vid => 'new' });
use Data::Dumper;
diag Dumper $product6->getCollateral('variantsJSON', 'vid', $newVid);
#----------------------------------------------------------------------------
# Cleanup
END {
WebGUI::VersionTag->getWorking($session)->rollback;
}
1;

49
t/Asset/Wobject/Survey/SurveyJSON.t
View file

@ -210,7 +210,7 @@ like( $surveyJSON->freeze, qr/"survey":\{\}/, 'freeze: got back something that l
my $stompedAddress = [];
is_deeply($surveyJSON->newObject($stompedAddress), [1], 'newObject returns the new data structure index');
is_deeply($stompedAddress, [], 'newObject does not stomp on the address argument if it is empty');
is_deeply($stompedAddress, [1], 'newObject stomps on $address');
cmp_deeply(
$surveyJSON->sections,
@ -421,9 +421,6 @@ cmp_deeply(
####################################################
my $section1 = $surveyJSON->getObject([2]);
##Now, there was a little naming problem created when inserting
##sections out of order. Let's fix it and show the danger of
##using references.
cmp_deeply(
$section1,
@ -434,6 +431,7 @@ cmp_deeply(
'getObject: Retrieved correct section'
);
##Try a reference stomp
$section1->{title} = 'Section 2';
cmp_deeply(
summarizeSectionSkeleton($surveyJSON),
@ -475,25 +473,19 @@ cmp_deeply(
],
},
{
title => 'Section 2',
title => 'Section 1',
questions => [],
},
],
'getObject: Returns live, dangerous references'
'getObject: Returns safe, cloned references'
);
my $question1 = $surveyJSON->getObject([1, 0]);
cmp_deeply(
$question1,
superhashof({
type => 'question',
text => 'Question 0+-0',
}),
'getObject: Retrieved correct question'
);
$surveyJSON->update([1], { title => 'Section 1'} );
##Propertly update a section
{
my $section = $surveyJSON->getObject([1]);
$section->{title} = 'Section 1';
$surveyJSON->update([1], $section );
}
cmp_deeply(
summarizeSectionSkeleton($surveyJSON),
[
@ -534,14 +526,26 @@ cmp_deeply(
],
},
{
title => 'Section 2',
title => 'Section 1',
questions => [],
},
],
'Update: updated a section'
);
$surveyJSON->update([1, 0], { text => 'Question 1-0'} );
my $question1 = $surveyJSON->getObject([1, 0]);
cmp_deeply(
$question1,
superhashof({
type => 'question',
text => 'Question 0+-0',
}),
'getObject: Retrieved correct question'
);
$question1->{text} = 'Question 1-0';
$surveyJSON->update([1, 0], $question1 );
cmp_deeply(
$surveyJSON->getObject([1, 0]),
@ -549,9 +553,6 @@ cmp_deeply(
type => 'question',
text => 'Question 1-0',
answers => [
superhashof ({
text => '',
}),
],
}),
'update: updating a question adds a new, default answer?'
@ -566,7 +567,7 @@ cmp_deeply(
answers => [
],
}),
'remove: removed that extra, default answer'
'remove: No problems with removing nonexistant data'
);