oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Packages used in upgrades get installed regardless of revisionDate. Fixes bug #11059

Browse source
This commit is contained in:
Colin Kuskie 2009-09-29 11:51:35 -07:00
parent aad5f55601
commit 270ecb948f
4 changed files with 41 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

36
t/Asset/AssetPackage.t
View file

@ -23,7 +23,7 @@ use WebGUI::VersionTag;
use Test::More; # increment this value for each test you create
use Test::MockObject;
plan tests => 10;
plan tests => 14;
my $session = WebGUI::Test->session;
$session->user({userId => 3});
@ -50,7 +50,7 @@ my $targetFolder = $root->addChild({
className => 'WebGUI::Asset::Wobject::Folder',
});
my $snippet = $folder->addChild({
my $subSnippet = $folder->addChild({
url => 'testSnippet',
title => 'snippet',
menuTitle => 'snippetMenuTitle',
@ -58,6 +58,14 @@ my $snippet = $folder->addChild({
snippet => 'A snippet of text',
});
my $snippet = $root->addChild({
url => 'snip_snip',
title => 'snip snip',
className => 'WebGUI::Asset::Snippet',
snippet => 'Always upgrade to the latest version',
isPackage => 1,
});
my $packageAssetId = $folder->getId;
$session->request->setup_body({ assetId => $packageAssetId });
@ -69,6 +77,17 @@ $versionTag->commit;
sleep 2;
my $storage = $snippet->exportPackage();
isa_ok($storage, 'WebGUI::Storage', 'exportPackage returns a WebGUI::Storage object');
my $snippetRev = $snippet->addRevision({ snippet => 'Only upgrade existing data if revisionDate is newer' });
is($snippetRev->get('snippet'), 'Only upgrade existing data if revisionDate is newer', 'importPackage, overwriteLatest: precondition check, content');
cmp_ok( $snippetRev->get('revisionDate'), '>', $snippet->get('revisionDate'), '... precondition check, revisionDate');
my $vt2 = WebGUI::VersionTag->getWorking($session);
$vt2->commit;
WebGUI::Test->tagsToRollback($vt2);
$targetFolder->www_deployPackage();
$targetFolderChildren = $targetFolder->getLineage(["children"], {returnObjects => 1,});
@ -93,7 +112,18 @@ $newVersionTag->commit;
my $newFolder = WebGUI::Asset->new($session, $folder->getId);
ok(! $newFolder->get('isPackage'), 'Disabled isPackage in original folder asset');
is(scalar @{ $root->getPackageList }, 0, 'getPackageList does not pick up old versions of assets that used to be packages');
sleep 1;
my $updatedSnippet = WebGUI::Asset->new($session, $snippet->getId);
$root->importPackage($storage, { overwriteLatest => 1 });
$updatedSnippet = WebGUI::Asset->new($session, $snippet->getId);
is($updatedSnippet->get('snippet'), 'Always upgrade to the latest version', 'importPackage: overwriteLatest causes revision dates to be ignored');
cmp_ok( $updatedSnippet->get('revisionDate'), '>', $snippetRev->get('revisionDate'), '... revisionDate check on imported package with overwriteLatest');
my $lastTag = WebGUI::VersionTag->getWorking($session);
WebGUI::Test->tagsToRollback($lastTag);
TODO: {
local $TODO = "Tests to make later";