[ 1441488 ] Sort Order of Profile Fields in Form "Create New Account"

fixed a few syntax things in Item.pm

docs/changelog/6.x.x.txt

@@ -59,6 +59,8 @@
  - Help for forms now shows the fields that you should see with your UI level.
    There is a link to show all fields.
  - fix [ 1445393 ] 6.9 WhatNext missing from DataForm editField
+ - fix [ 1443378 ] 6.99 Commerce system needs to be sessionized
+ - fix [ 1442942 ] 6.99: listLDAPLinks broken
 
 6.8.8
  - fix [ 1437186 ] 6.8.7 deploy DataForm package does not copy fields
@@ -69,6 +71,9 @@
    bars
  - fixed a delete bug on cs posts.
  - fixed two security problems with www_process in DataForm.pm
+ - [ 1441488 ] Sort Order of Profile Fields in Form "Create New Account"
+ - fix [ 1439352 ] Deleting post is chain of posts ... descendants
+ - fix [ 1432491 ] 6.8.6 popup windows has not head & body tags
 
 6.8.7
  - fix [ 1431098 ] op=becomeUser can become non-existent userIds

lib/WebGUI/Commerce/Item.pm

@@ -55,6 +55,7 @@ This returns the description of the item. This must be implemented by an item pl
 =cut
 
 sub description {
+	my $self = shift;
 	return $self->session->errorHandler->fatal('The description method of WebGUI::Commerce::Item must be overridden.');
 }
 
@@ -95,6 +96,7 @@ by an item plugin.
 =cut
 
 sub id {
+	my $self = shift;
 	return $self->session->errorHandler->fatal('The id method of WebGUI::Commerce::Item must be overridden.');
 }
 
@@ -120,6 +122,7 @@ Returns the name of the item. This must be implemented by an item plugin.
 =cut
 
 sub name {
+	my $self = shift;
 	return $self->session->errorHandler->fatal('The name method of WebGUI::Commerce::Item must be overridden.');
 }
 
@@ -183,6 +186,7 @@ term price. This must be implemented by an item plugin.
 =cut
 
 sub price {
+	my $self = shift;
 	return $self->session->errorHandler->fatalError('The price method of WebGUI::Commerce::Item must be overridden.');
 }
 
@@ -195,6 +199,7 @@ Returns the type (namespace) of the item.
 =cut 
 
 sub type {
+	my $self = shift;
 	return $self->session->errorHandler->fatalError('The type method of WebGUI::Commerce::Item must be overridden.');
 }
 

lib/WebGUI/Commerce/Item/Product.pm

@@ -60,6 +60,7 @@ Overload default constructor to glue in a WebGUI::Product object.
 sub new {
 	my ($class, $session, $sku, $product, $variantId);
 	$class = shift;
+	$session = shift;
 	$variantId = shift;
 	
 	$product = WebGUI::Product->getByVariantId($session,$variantId);

lib/WebGUI/ProfileField.pm

@@ -292,12 +292,12 @@ Returns an array reference of WebGUI::ProfileField objects that are marked "requ
 =cut
 
 sub getRequiredFields {
-        my $self = shift;
+	my $self = shift;
-        my @fields = ();
+	my @fields = ();
-        foreach my $fieldName ($self->session->db->buildArray("select fieldName from userProfileField where required=1 order by sequenceNumber")) {
+	foreach my $fieldName ($self->session->db->buildArray("select userProfileField.fieldName from  userProfileField LEFT JOIN userProfileCategory ON userProfileField.profileCategoryId = userProfileCategory.profileCategoryId where userProfileField.required=1 order by userProfileCategory.sequenceNumber, userProfileField.sequenceNumber")) {
-                push(@fields,WebGUI::ProfileField->new($self->session,$fieldName));
+		push(@fields,WebGUI::ProfileField->new($self->session,$fieldName));
-        }
+	}
-        return \@fields;
+	return \@fields;
 }
 
 #-------------------------------------------------------------------