oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Changing some SQL methods to quote table names

Browse source
This commit is contained in:
Yung Han Khoe 2009-11-16 12:11:45 +01:00
parent df84c60d6a
commit 2987ed44bc
1 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
lib/WebGUI/SQL.pm
View file

@ -484,7 +484,7 @@ The value to search for in the key column.
sub deleteRow { sub deleteRow {
my ($self, $table, $key, $keyValue) = @_; my ($self, $table, $key, $keyValue) = @_;
my $sth = $self->write("delete from $table where ".$key."=?", [$keyValue]); my $sth = $self->write("delete from ".$self->dbh->quote_identifier($table)." where ".$key."=?", [$keyValue]);
} }
@ -606,7 +606,7 @@ The value to search for in the key column.
sub getRow { sub getRow {
my ($self, $table, $key, $keyValue) = @_; my ($self, $table, $key, $keyValue) = @_;
my $row = $self->quickHashRef("select * from $table where ".$key."=?",[$keyValue]); my $row = $self->quickHashRef("select * from ".$self->dbh->quote_identifier($table)." where ".$key."=?",[$keyValue]);
return $row; return $row;
} }
@ -946,7 +946,8 @@ sub setRow {
my ($self, $table, $keyColumn, $data, $id) = @_; my ($self, $table, $keyColumn, $data, $id) = @_;
if ($data->{$keyColumn} eq "new" || $id) { if ($data->{$keyColumn} eq "new" || $id) {
$data->{$keyColumn} = $id || $self->session->id->generate(); $data->{$keyColumn} = $id || $self->session->id->generate();
$self->write("replace into $table (" . $self->dbh->quote_identifier($keyColumn) . ") values (?)",[$data->{$keyColumn}]); $self->write("replace into ".$self->dbh->quote_identifier($table)
." (" . $self->dbh->quote_identifier($keyColumn) . ") values (?)",[$data->{$keyColumn}]);
} }
my @fields = (); my @fields = ();
my @data = (); my @data = ();
@ -958,7 +959,7 @@ sub setRow {
} }
if ($fields[0] ne "") { if ($fields[0] ne "") {
push(@data,$data->{$keyColumn}); push(@data,$data->{$keyColumn});
$self->write("update $table set " . join(", ", @fields) $self->write("update ".$self->dbh->quote_identifier($table)." set " . join(", ", @fields)
. " where " . $self->dbh->quote_identifier($keyColumn) . "=?", \@data); . " where " . $self->dbh->quote_identifier($keyColumn) . "=?", \@data);
} }
return $data->{$keyColumn}; return $data->{$keyColumn};