classes under session should weaken their session references

This commit is contained in:
Graham Knop 2010-04-16 19:29:18 -05:00
parent 241c94175f
commit 2b78fe913b
17 changed files with 81 additions and 248 deletions

View file

@ -17,13 +17,11 @@ package WebGUI::Session::ErrorHandler;
use strict;
use WebGUI::Paths;
use JSON;
use HTML::Entities qw(encode_entities);
use Log::Log4perl;
use WebGUI::Exception;
use Sub::Uplevel;
use Scalar::Util qw(weaken);
=head1 NAME
=head1 NAME
Package WebGUI::Session::ErrorHandler
@ -201,6 +199,8 @@ sub new {
my $class = shift;
my $session = shift;
my $self = bless { _session => $session }, $class;
weaken $self->{_session};
my $logger = $session->request && $session->request->logger;
if ( !$logger ) {
@ -215,8 +215,8 @@ sub new {
$log4perl->$level( $args->{message} );
};
}
bless { _session => $session, _logger => $logger }, $class;
$self->{_logger} = $logger;
return $self;
}
#----------------------------------------------------------------------------