oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Survey JSON performance warning for non-wre-standard JSON modules/versions

Browse source 
If you have funny combinations of JSON, JSON::XS and JSON::PP installed,
JSON can start deciding to use JSON::PP instead of JSON::XS, which equals
bad performance on very large Survey instances.

This commit adds a new warning to the Edit Survey page if JSON->backend
is detected to be something other than JSON::XS.
This commit is contained in:
Patrick Donelan 2009-08-09 06:25:49 +00:00
parent af2d858f68
commit 2cc10d2953
2 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
docs/changelog/7.x.x.txt
View file

@ -37,6 +37,7 @@
- fixed Survey ExpireIncompleteSurveyResponses Workflow Activity not enabled (Patrick Donelan, SDH Consulting) - fixed Survey ExpireIncompleteSurveyResponses Workflow Activity not enabled (Patrick Donelan, SDH Consulting)
- fixed #10689: Version Tag Modes (Henry Tang, Long Term Results B.V.) - fixed #10689: Version Tag Modes (Henry Tang, Long Term Results B.V.)
- fixed #10733: viewing pending version tags - fixed #10733: viewing pending version tags
- added Survey JSON performance warning for people with non-wre-standard JSON modules/versions (Patrick Donelan, SDH Consulting)
7.7.16 7.7.16
- fixed #10590: Session::DateTime->secondsToInterval doesn't allow 7 weeks - fixed #10590: Session::DateTime->secondsToInterval doesn't allow 7 weeks

3
lib/WebGUI/Asset/Wobject/Survey/SurveyJSON.pm
View file

@ -1371,6 +1371,9 @@ sub validateSurvey{
my $self = shift; my $self = shift;
my @messages; my @messages;
if (JSON->backend ne 'JSON::XS') {
push @messages, "Your server is using @{[JSON->backend]} as its JSON backend. This may hurt performance on large Survey instances";
}
#set up valid goto targets #set up valid goto targets
my $gotoTargets = $self->getGotoTargets(); my $gotoTargets = $self->getGotoTargets();