oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Update Ship master class for new ShipDriver requirements.

Browse source
This commit is contained in:
Colin Kuskie 2010-10-14 19:34:25 -07:00
parent 499feb420b
commit 30ff4597c8
2 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
lib/WebGUI/Shop/Ship.pm
View file

@ -73,7 +73,8 @@ sub addShipper {
unless exists $self->getDrivers->{$requestedClass}; unless exists $self->getDrivers->{$requestedClass};
WebGUI::Error::InvalidParam->throw(error => q{You must pass a hashref of options to create a new ShipDriver object}) WebGUI::Error::InvalidParam->throw(error => q{You must pass a hashref of options to create a new ShipDriver object})
unless defined($options) and ref $options eq 'HASH' and scalar keys %{ $options }; unless defined($options) and ref $options eq 'HASH' and scalar keys %{ $options };
my $driver = eval { WebGUI::Pluggable::instanciate($requestedClass, 'create', [ $self->session, $options ]) }; my $driver = eval { WebGUI::Pluggable::instanciate($requestedClass, 'new', [ $self->session, $options ]) };
$driver->write;
return $driver; return $driver;
} }

4
t/Shop/Ship.t
View file

@ -124,13 +124,13 @@ cmp_deeply(
eval { $shipper = $ship->addShipper('WebGUI::Shop::ShipDriver::FlatRate', {}); }; eval { $shipper = $ship->addShipper('WebGUI::Shop::ShipDriver::FlatRate', {}); };
$e = Exception::Class->caught(); $e = Exception::Class->caught();
isa_ok($e, 'WebGUI::Error::InvalidParam', 'addShipper croaks without options to build a object with'); isa_ok($e, 'WebGUI::Error::InvalidParam', 'addShipper croaks with empty options to build a object with');
cmp_deeply( cmp_deeply(
$e, $e,
methods( methods(
error => 'You must pass a hashref of options to create a new ShipDriver object', error => 'You must pass a hashref of options to create a new ShipDriver object',
), ),
'addShipper croaks without options to build a object with', 'addShipper croaks with empty options to build a object with',
); );
my $driver = $ship->addShipper('WebGUI::Shop::ShipDriver::FlatRate', { enabled=>1, label=>q{Jake's Jailbird Airmail}, groupToUse=>7}); my $driver = $ship->addShipper('WebGUI::Shop::ShipDriver::FlatRate', { enabled=>1, label=>q{Jake's Jailbird Airmail}, groupToUse=>7});