oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Corner cases for User.pm coverage

Browse source 
Converted 2 more queries to use placeholders
This commit is contained in:
Colin Kuskie 2007-02-24 00:37:55 +00:00
parent 2a0eb20bc7
commit 31139678ee
2 changed files with 21 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

6
lib/WebGUI/User.pm
View file

@ -388,7 +388,7 @@ sub new {
%user = $session->db->quickHash("select * from users where userId=?",[$userId]);
my %profile = $session->db->buildHash("select userProfileField.fieldName, userProfileData.fieldData
from userProfileField, userProfileData where userProfileField.fieldName=userProfileData.fieldName and
userProfileData.userId=".$session->db->quote($user{userId}));
userProfileData.userId=?",[$user{userId}]);
my %default = $session->db->buildHash("select fieldName, dataDefault from userProfileField");
foreach my $key (keys %default) {
my $value;
@ -582,8 +582,8 @@ sub username {
$self->uncache;
$self->{_user}{"username"} = $value;
$self->{_user}{"lastUpdated"} = $self->session->datetime->time();
$self->session->db->write("update users set username=".$self->session->db->quote($value).",
lastUpdated=".$self->session->datetime->time()." where userId=".$self->session->db->quote($self->userId));
$self->session->db->write("update users set username=?, lastUpdated=? where userId=?",
[$value, $self->session->datetime->time(), $self->userId]);
}
return $self->{_user}{"username"};
}

26
t/User.t
View file

@ -18,7 +18,7 @@ use WebGUI::Utility;
use WebGUI::Cache;
use WebGUI::User;
use Test::More tests => 90; # increment this value for each test you create
use Test::More tests => 93; # increment this value for each test you create
my $session = WebGUI::Test->session;
@ -83,8 +83,16 @@ cmp_ok(abs($user->lastUpdated-$lastUpdate), '<=', 1, 'lastUpdated() -- authmetho
#See if date created is correct
is($user->dateCreated, $userCreationTime, 'dateCreated()');
#get/set karma
################################################################
#
# get/set karma
#
################################################################
my $oldKarma = $user->karma;
$user->karma('69');
$user->karma('69', 'wonder man');
is($user->karma, $oldKarma, 'karma() -- requires amount, source and description');
$user->karma('69', 'peter gibbons', 'test karma');
is($user->karma, $oldKarma+69, 'karma() -- get/set add amount');
@ -261,6 +269,7 @@ $cm->ipFilter(defined $origFilter ? $origFilter : '');
##Test for group membership
$user = WebGUI::User->new($session, "new");
ok($user->isInGroup(7), "addToGroups: New user is in group 7(Everyone)");
ok(!$user->isInGroup(1), "New user not in group 1 (Visitors)");
$user->addToGroups([3]);
@ -273,15 +282,16 @@ ok($user->isInGroup(14), "New user is in group 14(Product Managers)");
$user->deleteFromGroups([3]);
ok(!$user->isInGroup(3), "deleteFromGroups: New user is not in group 3(Admin)");
ok(!$user->isInGroup(11), "Flush cache, new user not in group 11 (Secondary Admins)");
ok(!$user->isInGroup(12), "Flush cache, new user not in group 12 (Turn On Admin)");
ok(!$user->isInGroup(13), "Flush cache, new user not in group 13 (Export Managers)");
ok(!$user->isInGroup(14), "Flush cache, new user not in group 14 (Product Managers)");
ok(!$user->isInGroup(11), "New user not in group 11 (Secondary Admins)");
ok(!$user->isInGroup(12), "New user not in group 12 (Turn On Admin)");
ok(!$user->isInGroup(13), "New user not in group 13 (Export Managers)");
ok(!$user->isInGroup(14), "New user not in group 14 (Product Managers)");
$user->delete;
ok($visitor->isInGroup(1), "Visitor is a member of group Visitor");
ok($visitor->isInGroup(7), "Visitor is a member of group Everyone");
ok($visitor->isInGroup(1), "Visitor is a member of group Visitor");
ok($visitor->isInGroup(7), "Visitor is a member of group Everyone");
ok(!$visitor->isInGroup(2), "Visitor is a not member of group 2 (Registered Users)");
##remove Visitor from those groups, and make sure we can add him back in.
WebGUI::Group->new($session, '1')->deleteUsers([1]);