From 31fc1bdd177279a6af98af8dd70a600535acd2a6 Mon Sep 17 00:00:00 2001
From: Matthew Wilson <matt@plainblack.com>
Date: Sat, 4 Feb 2006 13:54:00 +0000
Subject: [PATCH] removed unneeded line from LDAP.pm, fixed empty returns from
 processOperations, and added more POD to PerformanceProfiler.pm

---
 lib/WebGUI.pm                     |  2 +-
 lib/WebGUI/Auth/LDAP.pm           |  1 -
 lib/WebGUI/PerformanceProfiler.pm | 20 +++++++++++++++++++-
 3 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/lib/WebGUI.pm b/lib/WebGUI.pm
index 44d406318..3482bd079 100644
--- a/lib/WebGUI.pm
+++ b/lib/WebGUI.pm
@@ -127,7 +127,7 @@ sub page {
 #-------------------------------------------------------------------
 sub processOperations {
 	my $session = shift;
-	my ($cmd, $output);
+	my $output = "";
 	my $op = $session->form->process("op");
 #	my $opNumber = shift || 1;
 	if ($op) {
diff --git a/lib/WebGUI/Auth/LDAP.pm b/lib/WebGUI/Auth/LDAP.pm
index 2d0db3422..7cc7f25d9 100644
--- a/lib/WebGUI/Auth/LDAP.pm
+++ b/lib/WebGUI/Auth/LDAP.pm
@@ -15,7 +15,6 @@ use WebGUI::Auth;
 use WebGUI::HTMLForm;
 use WebGUI::Form;
 use WebGUI::LDAPLink;
-use WebGUI::Mail;
 use WebGUI::Utility;
 use WebGUI::Operation::Shared;
 use WebGUI::Asset::Template;
diff --git a/lib/WebGUI/PerformanceProfiler.pm b/lib/WebGUI/PerformanceProfiler.pm
index 7f8dfec9d..d3c2938d3 100755
--- a/lib/WebGUI/PerformanceProfiler.pm
+++ b/lib/WebGUI/PerformanceProfiler.pm
@@ -44,7 +44,8 @@ PerlModule WebGUI::PerformanceProfiler
 PerlChildInitHandler WebGUI::PerformanceProfiler
 PerlOutputFilterHandler WebGUI::PerformanceProfiler
 
-To the apache configuration.
+To the apache configuration.  Make sure these directives
+are not inside your WebGUI vhost block, but instead above it.
 
 By default all preloaded WebGUI code will get profiled. 
 You can limit the profiling to specific modules like this:
@@ -225,6 +226,23 @@ sub profileSubEnd {
 	$depth--;
 }
 
+
+=head2 results
+
+Produce the output of the profiler.  The expandable, 
+collapsible tree of subroutine calls.  Will soon 
+include line number of the caller (parent) subroutine, 
+and optionally a dump of all the parameters (!). Will 
+also soon include a tabular display akin to Devel::DProf's 
+formatted tabular output: percent total time spent in sub, 
+aggregate exclusive time spent in sub, aggregate inclusive 
+time spent in sub, number of calls to the sub, mean 
+exclusive time per sub call, mean inclusive time per sub 
+call, subroutine name, sorted by aggregate exclusive time 
+per sub, descending.
+
+=cut
+
 sub results {
 	my $output = qq|
 <script>