oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

missing session variables from ->new found via code analysis

Browse source
This commit is contained in:
Colin Kuskie 2006-01-16 21:55:39 +00:00
parent 4085c7baf4
commit 35c4ad353d
12 changed files with 36 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

6
lib/WebGUI/Asset/Wobject/Collaboration.pm
View file

@ -211,7 +211,7 @@ sub canView {
#-------------------------------------------------------------------
sub createSubscriptionGroup {
my $self = shift;
my $group = WebGUI::Group->new("new");
my $group = WebGUI::Group->new($self->session, "new");
$group->name($self->getId);
$group->description("The group to store subscriptions for the collaboration system ".$self->getId);
$group->isEditable(0);
@ -806,7 +806,7 @@ sub processPropertiesFromFormPost {
#-------------------------------------------------------------------
sub purge {
my $self = shift;
my $group = WebGUI::Group->new($self->get("subscriptionGroupId"));
my $group = WebGUI::Group->new($self->session, $self->get("subscriptionGroupId"));
$group->delete;
$self->SUPER::purge;
}
@ -1162,7 +1162,7 @@ sub www_viewRSS {
order by ".$self->getValue("sortBy")." ".$self->getValue("sortOrder"));
my $i = 1;
while (my ($id, $class, $version) = $sth->array) {
my $post = WebGUI::Asset::Wobject::Collaboration->new($id, $class, $version);
my $post = WebGUI::Asset::Wobject::Collaboration->new($self->session, $id, $class, $version);
my $encUrl = _xml_encode($self->session->url->getSiteURL().$post->getUrl);
my @attachmentLoop = ();

6
lib/WebGUI/Asset/Wobject/Dashboard.pm
View file

@ -81,7 +81,7 @@ sub definition {
sub getContentPositions {
my $self = shift;
my $dummy = $self->initialize unless $self->get("isInitialized");
my $u = WebGUI::User->new($self->discernUserId);
my $u = WebGUI::User->new($self->session, $self->discernUserId);
return $u->profileField($self->getId.'contentPositions');
}
@ -190,7 +190,7 @@ sub view {
}
}
my $i = 1;
my $templateAsset = WebGUI::Asset->newByDynamicClass($templateId) || WebGUI::Asset->getImportNode;
my $templateAsset = WebGUI::Asset->newByDynamicClass($self->session, $templateId) || WebGUI::Asset->getImportNode;
my $template = $templateAsset->get("template");
my $numPositions = 1;
foreach my $j (2..15) {
@ -276,7 +276,7 @@ sub www_setContentPositions {
return $self->session->privilege->insufficient() unless ($self->canPersonalize);
return 'empty' unless $self->get("isInitialized");
my $dummy = $self->initialize unless $self->get("isInitialized");
my $u = WebGUI::User->new($self->discernUserId);
my $u = WebGUI::User->new($self->session, $self->discernUserId);
my $success = $u->profileField($self->getId.'contentPositions',$self->session->form->process("map")) eq $self->session->form->process("map");
return "Map set: ".$self->session->form->process("map") if $success;
return "Map failed to set.";

2
lib/WebGUI/Asset/Wobject/HttpProxy.pm
View file

@ -302,7 +302,7 @@ sub view {
$var{content} = $1 || $var{content};
$var{"content.trailing"} = $2;
}
my $p = WebGUI::Asset::Wobject::HttpProxy::Parse->new($proxiedUrl, $var{content}, $self->getId,$self->get("rewriteUrls"),$self->getUrl);
my $p = WebGUI::Asset::Wobject::HttpProxy::Parse->new($self->session, $proxiedUrl, $var{content}, $self->getId,$self->get("rewriteUrls"),$self->getUrl);
$var{content} = $p->filter; # Rewrite content. (let forms/links return to us).
$p->DESTROY;

5
lib/WebGUI/Asset/Wobject/HttpProxy/Parse.pm
View file

@ -44,6 +44,7 @@ sub DESTROY {
sub new {
my $pack = shift;
my $self = $pack->SUPER::new();
$self->{_session} = shift;
$self->{Url} = shift;
$self->{Content} = shift;
$self->{assetId} = shift;
@ -92,6 +93,10 @@ sub end {
$_[0]->output("</$_[1]>")
}
sub session {
return $_[0]->{_session};
}
sub start {
my $self = shift;
my ($tag, $attr, $attrseq, $origtext) = @_;

6
lib/WebGUI/Asset/Wobject/Matrix.pm
View file

@ -326,7 +326,7 @@ sub www_deleteListingConfirm {
my $self = shift;
return $self->session->privilege->insufficient() unless($self->canEdit);
my $listing = $self->session->db->getRow("Matrix_listing","listingId",$self->session->form->process("listingId"));
WebGUI::Asset::Wobject::Collaboration->new($listing->{forumId})->purge;
WebGUI::Asset::Wobject::Collaboration->new($self->session, $listing->{forumId})->purge;
$self->session->db->write("delete from Matrix_listing where listingId=".$self->session->db->quote($self->session->form->process("listingId")));
$self->session->db->write("delete from Matrix_listingData where listingId=".$self->session->db->quote($self->session->form->process("listingId")));
$self->session->db->write("delete from Matrix_rating where listingId=".$self->session->db->quote($self->session->form->process("listingId")));
@ -970,11 +970,11 @@ sub www_viewDetail {
my %var;
my $i18n = WebGUI::International->new($self->session,'Asset_Matrix');
my $listing = $self->session->db->getRow("Matrix_listing","listingId",$listingId);
my $forum = WebGUI::Asset::Wobject::Collaboration->new($listing->{forumId});
my $forum = WebGUI::Asset::Wobject::Collaboration->new($self->session, $listing->{forumId});
$var{"discussion"} = $forum->view;
if ($self->session->form->process("do") eq "sendEmail") {
if ($self->session->form->process("body") ne "") {
my $u = WebGUI::User->new($listing->{maintainerId});
my $u = WebGUI::User->new($self->session, $listing->{maintainerId});
WebGUI::Mail::send($u->profileField("email"),$listing->{productName}." - ".$self->session->form->process("subject"),$self->session->form->process("body"),"",$self->session->form->process("from"));
}
$var{'email.wasSent'} = 1;

2
lib/WebGUI/Asset/Wobject/MessageBoard.pm
View file

@ -65,7 +65,7 @@ sub view {
$first = $child;
}
my %lastPostVars;
my $lastPost = WebGUI::Asset::Wobject::MessageBoard->newByDynamicClass($child->get("lastPostId"));
my $lastPost = WebGUI::Asset::Wobject::MessageBoard->newByDynamicClass($self->session, $child->get("lastPostId"));
if (defined $lastPost) {
%lastPostVars = (
'forum.lastPost.url' => $lastPost->getUrl,