Convert many search forms from POST to GET. Fixes bug ##11372

docs/changelog/7.x.x.txt

@@ -2,6 +2,7 @@
  - fixed #11362: Unable to checkout with ITransact plugin
  - fixed #11364: Notify About Low Stock workflow activity email is not user friendly
  - fixed #11371: Spaces in the names of custom profile fields
+ - fixed #11372: All Search Forms should use GET
 
 7.8.10
  - fixed #11332: Pagination in webgui.org forum urls

lib/WebGUI/Asset/Wobject/Calendar.pm

@@ -2120,6 +2120,7 @@ sub www_search {
     $var->{"form.header"}    
         = WebGUI::Form::formHeader($session, {
             action      => $self->getUrl,
+            method      => 'GET',
         })
         . WebGUI::Form::hidden($self->session, {
             name        => "func",

lib/WebGUI/Asset/Wobject/Collaboration.pm

@@ -1624,7 +1624,8 @@ sub www_search {
 	
     my $query   = $self->session->form->process("query","text");
     $var->{'form.header'} = WebGUI::Form::formHeader($self->session,{
-        action=>$self->getUrl("func=search;doit=1")
+        action=> $self->getUrl("func=search;doit=1"),
+        method=> 'GET',
     });
     $var->{'query.form'}  = WebGUI::Form::text($self->session,{
         name  => 'query',

lib/WebGUI/Asset/Wobject/StoryArchive.pm

@@ -598,7 +598,7 @@ sub viewTemplateVariables {
     }
     $var->{keywordCloud}   = WebGUI::Keyword->new($session)->generateCloud($cloudOptions);
     if (! $exporting) {
-        $var->{searchHeader} = WebGUI::Form::formHeader($session, { action => $self->getUrl })
+        $var->{searchHeader} = WebGUI::Form::formHeader($session, { action => $self->getUrl, method => 'GET',  })
                              . WebGUI::Form::hidden($session, { name   => 'func',   value => 'view' });
         $var->{searchFooter} = WebGUI::Form::formFooter($session);
         $var->{searchButton} = WebGUI::Form::submit($session, { name => 'search',   value => $i18n->get('search','Asset')});

lib/WebGUI/Asset/Wobject/UserList.pm

@@ -602,7 +602,7 @@ sub view {
 	$var{user_loop}             = \@users;
     $var{alphabetSearch_loop}   = $self->getAlphabetSearchLoop($self->get("alphabetSearchField"),$self->get("alphabet"));
 
-	$var{searchFormHeader}      = WebGUI::Form::formHeader($self->session,{action => $self->getUrl});
+	$var{searchFormHeader}      = WebGUI::Form::formHeader($self->session,{action => $self->getUrl, method => 'GET', });
     $var{searchFormSubmit}      = WebGUI::Form::submit($self->session,{value => $i18n->get('submit search label')});
     $var{searchFormFooter}      = WebGUI::Form::formFooter($self->session);
 

lib/WebGUI/Asset/Wobject/WikiMaster.pm

@@ -148,7 +148,7 @@ sub appendSearchBoxVars {
 	my $queryText = shift;
 	my $submitText = WebGUI::International->new($self->session, 'Asset_WikiMaster')->get('searchLabel');
 	$var->{'searchFormHeader'} = join '',
-	    (WebGUI::Form::formHeader($self->session, { action => $self->getUrl}),
+	    (WebGUI::Form::formHeader($self->session, { action => $self->getUrl, method => 'GET', }),
 	     WebGUI::Form::hidden($self->session, { name => 'func', value => 'search' }));
 	$var->{'searchQuery'} = WebGUI::Form::text($self->session, { name => 'query', value => $queryText });
 	$var->{'searchSubmit'} = WebGUI::Form::submit($self->session, { value => $submitText });

lib/WebGUI/Operation/Group.pm

@@ -196,7 +196,7 @@ sub getGroupSearchForm {
 	}
 	my $output = '<div align="center">';
 	my $i18n = WebGUI::International->new($session);
-	my $f = WebGUI::HTMLForm->new($session,1);
+	my $f = WebGUI::HTMLForm->new($session, method => 'GET', );
 	foreach my $key (keys %{$params}) {
                 $f->hidden(
                         -name=>$key,
@@ -1012,7 +1012,7 @@ sub www_manageUsersInGroup {
 	my $session = shift;
     return $session->privilege->adminOnly() unless (canEditGroup($session,$session->form->process("gid")));
 	my $i18n = WebGUI::International->new($session);
-	my $output = WebGUI::Form::formHeader($session,)
+	my $output = WebGUI::Form::formHeader($session,{ method => 'GET', })
 		.WebGUI::Form::hidden($session,{
 			name=>"gid",
 			value=>$session->form->process("gid")

lib/WebGUI/Operation/User.pm

@@ -277,7 +277,7 @@ sub getUserSearchForm {
 	$session->scratch->set("userSearchModifier",$session->form->process("modifier")) if defined($session->form->process("modifier"));
 	my $i18n = WebGUI::International->new($session);
 	my $output = '<div align="center">'
-		.WebGUI::Form::formHeader($session,)
+		.WebGUI::Form::formHeader($session,{ method => 'GET'}, )
 		.WebGUI::Form::hidden($session,
 			name => "op",
 			value => $op