oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix Interval form value preservation, when the field is hidden. Fixes bug #11431.

Browse source
This commit is contained in:
Colin Kuskie 2010-02-23 11:15:54 -08:00
parent 9c0cdde323
commit 3971d9bd4f
2 changed files with 39 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

1
docs/changelog/7.x.x.txt
View file

@ -4,6 +4,7 @@
- fixed #11414: SQLReport Pagination Setting
- fixed #11420: Snippet not save mimetype
- fixed #11422: Disabled scheduled task run by spectre
- fixed #11431: Prototypes cache attribute lost
7.8.12
- fixed #11285: Pasting HTML into Code Editor in IE

59
lib/WebGUI/Form/Interval.pm
View file

@ -95,6 +95,29 @@ sub getName {
#-------------------------------------------------------------------
=head2 getUnitOptions ( )
Returns a hash with i18n labels and values for units of time.
=cut
sub getUnitOptions {
my $self = shift;
tie my %units, 'Tie::IxHash';
my $i18n = WebGUI::International->new($self->session);
%units = (seconds => $i18n->get(704),
minutes => $i18n->get(705),
hours => $i18n->get(706),
days => $i18n->get(700),
weeks => $i18n->get(701),
months => $i18n->get(702),
years => $i18n->get(703),
);
return %units;
}
#-------------------------------------------------------------------
=head2 getValue ( [ num_and_units ] )
Returns either the interval that was posted (in seconds) or if nothing comes back it returns 0.
@ -165,17 +188,7 @@ Renders an interval control.
sub toHtml {
my $self = shift;
my %units;
tie %units, 'Tie::IxHash';
my $i18n = WebGUI::International->new($self->session);
%units = (seconds => $i18n->get(704),
minutes => $i18n->get(705),
hours => $i18n->get(706),
days => $i18n->get(700),
weeks => $i18n->get(701),
months => $i18n->get(702),
years => $i18n->get(703),
);
my %units = $self->getUnitOptions();
my %reverseUnits = reverse %units;
my ($interval, $units) = $self->session->datetime->secondsToExactInterval($self->getOriginalValue);
# not sure why, but these things need to be defined like this or
@ -208,16 +221,20 @@ Returns the field as hidden controls rather than displayable controls.
=cut
sub toHtmlAsHidden {
my $self = shift;
my ($interval, $units) = $self->session->datetime->secondsToExactInterval($self->getOriginalValue);
return WebGUI::Form::Hidden->new($self->session,
name=>$self->get("name").'_interval',
value=>$interval
)->toHtmlAsHidden
.WebGUI::Form::Hidden->new($self->session,
name=>$self->get("name").'_units',
value=>$units
)->toHtmlAsHidden;
my $self = shift;
my $session = $self->session;
my %units = $self->getUnitOptions();
my %reverseUnits = reverse %units;
my ($interval, $units) = $session->datetime->secondsToExactInterval($self->getOriginalValue);
my $unitVal = $reverseUnits{$units};
return WebGUI::Form::Hidden->new($session,
name => $self->get("name").'_interval',
value => $interval,
)->toHtmlAsHidden
. WebGUI::Form::Hidden->new($session,
name => $self->get("name").'_units',
value => $unitVal,
)->toHtmlAsHidden;
}
1;