oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: newByDynamicClass cannot die if given bad arguments, should return undef instead.

Browse source
This commit is contained in:
Doug Bell 2008-01-24 18:01:57 +00:00
parent 70a1c8c252
commit 3b9be36035
1 changed files with 10 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

16
lib/WebGUI/Asset.pm
View file

@ -1787,12 +1787,16 @@ sub newByDynamicClass {
my $session = shift;
my $assetId = shift;
my $revisionDate = shift;
confess "newByDynamicClass requires WebGUI::Session"
unless $session && blessed $session eq 'WebGUI::Session';
confess "newByDynamicClass requires assetId"
unless $assetId;
# Some code requires that these situations not die.
# confess "newByDynamicClass requires WebGUI::Session"
# unless $session && blessed $session eq 'WebGUI::Session';
# confess "newByDynamicClass requires assetId"
# unless $assetId;
# So just return instead
return unless ( $session && blessed $session eq 'WebGUI::Session' )
&& $assetId;
# Cache the className lookup
my $assetClass = $session->stow->get("assetClass");
my $className = $assetClass->{$assetId};