oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Collab / Thread / Post ratings were being incorrectly calculated

Browse source
This commit is contained in:
Doug Bell 2007-09-07 16:42:54 +00:00
parent d03a377c11
commit 3ea18fc8d4
4 changed files with 71 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

42
lib/WebGUI/Asset/Post/Thread.pm
View file

@ -791,26 +791,28 @@ Update the cumulative ratings in this thread
=cut
sub updateThreadRating {
my $self = shift;
my $ratingSumSQL = <<EOSQL;
select sum(Post.rating) from Post
left join assetData on
Post.assetId=assetData.assetId
left join asset on
asset.assetId=assetData.assetId
and assetData.revisionDate=(SELECT max(revisionDate) from assetData where assetData.assetId=asset.assetId)
where
Post.threadId=?
EOSQL
my ($sum) = $self->session->db->quickArray($ratingSumSQL, [$self->getId]);
$self->update({threadRating=>$sum});
my $parent = $self->getParent;
if (defined $parent) {
$parent->recalculateRating;
} else {
$self->session->errorHandler->error("Couldn't get parent for thread ".$self->getId);
}
my $self = shift;
my $session = $self->session;
my $calcRating = 0;
my $postIds = $self->getLineage(["descendants","self"], {
includeOnlyClasses => ["WebGUI::Asset::Post","WebGUI::Asset::Post::Thread"],
});
$calcRating += $session->db->quickScalar(
"SELECT SUM(rating) FROM Post_rating WHERE assetId IN (".$session->db->quoteAndJoin($postIds).")"
);
$self->update({
threadRating => $calcRating
});
my $parent = $self->getParent;
if (defined $parent) {
$parent->recalculateRating;
} else {
$self->session->errorHandler->error("Couldn't get parent for thread ".$self->getId);
}
}

36
lib/WebGUI/Asset/Wobject/Collaboration.pm
View file

@ -1166,14 +1166,34 @@ Calculates the rating of this forum from its threads and stores the new value in
=cut
sub recalculateRating {
my $self = shift;
my ($count) = $self->session->db->quickArray("select count(*) from Thread left join asset on Thread.assetId=asset.assetId
left join Post on Thread.assetId=Post.assetId where asset.parentId=?",[$self->getId]);
$count = $count || 1;
my ($sum) = $self->session->db->quickArray("select sum(Post.rating) from Thread left join asset on Thread.assetId=asset.assetId
left join Post on Thread.assetId=Post.assetId where asset.parentId=?",[$self->getId]);
my $average = round($sum/$count);
$self->update({rating=>$average});
my $self = shift;
# Get the number of threads
my ($count)
= $self->session->db->quickArray(
"select count(*) from Thread
left join asset on Thread.assetId=asset.assetId
left join Post on Thread.assetId=Post.assetId
AND Thread.revisionDate = (SELECT MAX(revisionDate) FROM Thread t WHERE t.assetId=asset.assetId)
where asset.parentId=?",
[$self->getId]
);
$count = $count || 1;
# Get the ratings of all the threads
my ($sum)
= $self->session->db->quickArray(
"SELECT SUM(Thread.threadRating)
FROM Thread
LEFT JOIN asset ON Thread.assetId=asset.assetId
LEFT JOIN Post ON Thread.assetId=Post.assetId
AND Thread.revisionDate = (SELECT MAX(revisionDate) FROM Thread t WHERE t.assetId=asset.assetId)
WHERE asset.parentId=?",
[$self->getId]
);
my $average = round($sum/$count);
$self->update({rating=>$average});
}