From 40a4c3c48754f0449264015a8e1e375468239ef1 Mon Sep 17 00:00:00 2001 From: JT Smith Date: Sun, 29 Jul 2007 21:26:35 +0000 Subject: [PATCH] fixing bugs reported by tests --- lib/WebGUI/Asset.pm | 2 +- lib/WebGUI/Commerce/Payment/Cash.pm | 1 + t/Asset/AssetLineage.t | 8 ++++---- t/Asset/Snippet.t | 2 ++ t/Form/ProfileEnabled.t | 2 +- 5 files changed, 9 insertions(+), 6 deletions(-) diff --git a/lib/WebGUI/Asset.pm b/lib/WebGUI/Asset.pm index befabfaaa..8d821e70d 100644 --- a/lib/WebGUI/Asset.pm +++ b/lib/WebGUI/Asset.pm @@ -2067,7 +2067,7 @@ sub update { next unless (exists $properties->{$property} || exists $definition->{properties}{$property}{defaultValue}); # skip a property if it has the display only flag set - next if ($properties->{property}{displayOnly}); + next if ($definition->{properties}{$property}{displayOnly}); # use the update value my $value = $properties->{$property}; diff --git a/lib/WebGUI/Commerce/Payment/Cash.pm b/lib/WebGUI/Commerce/Payment/Cash.pm index 396d9b80e..c27a0ea91 100644 --- a/lib/WebGUI/Commerce/Payment/Cash.pm +++ b/lib/WebGUI/Commerce/Payment/Cash.pm @@ -189,6 +189,7 @@ sub errorCode { } #------------------------------------------------------------------- + =head2 label ( ) Returns the label for the commerce plugin. diff --git a/t/Asset/AssetLineage.t b/t/Asset/AssetLineage.t index 42f6aa516..7774d5504 100644 --- a/t/Asset/AssetLineage.t +++ b/t/Asset/AssetLineage.t @@ -245,10 +245,10 @@ is(scalar @snippets, $folder->getChildCount, 'changing lineage does not change is(1 , $folder2->getChildCount, 'changing lineage does not change relationship in folder2'); ##Reinstance the asset object due to db manipulation -$folder = WebGUI::Asset->newByUrl($session, $folder->get('url')); -$folder2 = WebGUI::Asset->newByUrl($session, $folder2->get('url')); -@snippets = map { WebGUI::Asset->newByUrl($session, "snippet$_") } 0..6; -$snippet2 = WebGUI::Asset->newByUrl($session, $snippet2->get('url')); +$folder = WebGUI::Asset->newByDynamicClass($session, $folder->getId); +$folder2 = WebGUI::Asset->newByDynamicClass($session, $folder2->getId); +@snippets = map { WebGUI::Asset->newByDynamicClass($session, $snippets[$_]->getId) } 0..6; +$snippet2 = WebGUI::Asset->newByDynamicClass($session, $snippet2->getId); #################################################### # diff --git a/t/Asset/Snippet.t b/t/Asset/Snippet.t index 27cca6445..889a73f0c 100644 --- a/t/Asset/Snippet.t +++ b/t/Asset/Snippet.t @@ -37,6 +37,8 @@ my $properties = { }; $snippet->update($properties); +use Data::Dumper; +Dumper($properties); foreach my $property (keys %{$properties}) { is ($snippet->get($property), $properties->{$property}, "updated $property is ".$properties->{$property}); } diff --git a/t/Form/ProfileEnabled.t b/t/Form/ProfileEnabled.t index f3137cddc..3fbd7adfa 100644 --- a/t/Form/ProfileEnabled.t +++ b/t/Form/ProfileEnabled.t @@ -40,7 +40,7 @@ $numTests = scalar @formTypes + 1; plan tests => $numTests; -my @notEnabled = qw/Asset Button Captcha Checkbox Color Control List MimeType SubscriptionGroup Slider Submit User/; +my @notEnabled = qw/Asset Button Captcha Checkbox Color Control List MimeType SubscriptionGroup Slider Submit User Attachments/; foreach my $formType (@formTypes) { my $form = WebGUI::Form::DynamicField->new($session, fieldType => $formType);