oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix exception handling by the NotifyAboutLowStock workflow activity. Fixes bug #11343.

Browse source
This commit is contained in:
Colin Kuskie 2010-01-12 11:07:43 -08:00
parent be7cd328cf
commit 47276ce4ad
3 changed files with 80 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

13
lib/WebGUI/Workflow/Activity/NotifyAboutLowStock.pm
View file

@ -91,14 +91,21 @@ See WebGUI::Workflow::Activity::execute() for details.
sub execute {
my ($self, undef, $instance) = @_;
my $session = $self->session;
my $message = $instance->getScratch('LowStockMessage') || '';
my $counter = $instance->getScratch('LowStockLast') || 0;
my $belowThreshold = $instance->getScratch('LowStockBelow') || 0;
my $productIterator = WebGUI::Asset::Sku::Product->getIsa($self->session, $counter);
my $productIterator = WebGUI::Asset::Sku::Product->getIsa($session, $counter);
my $warningLimit = $self->get('warningLimit');
my $finishTime = time() + $self->getTTL;
my $expired = 0;
PRODUCT: while (my $product = $productIterator->()) {
PRODUCT: while (1) {
my $product = eval { $productIterator->() };
if (my $e = Exception::Class->caught()) {
$session->log->error($@);
next PRODUCT;
}
last PRODUCT unless $product;
VARIANT: foreach my $collateral ( @{ $product->getAllCollateral('variantsJSON') }) {
if ($collateral->{quantity} <= $warningLimit) {
##Build message
@ -126,7 +133,7 @@ sub execute {
$instance->deleteScratch('LowStockLast');
$instance->deleteScratch('LowStockBelow');
if ($belowThreshold) {
my $inbox = WebGUI::Inbox->new($self->session);
my $inbox = WebGUI::Inbox->new($session);
$inbox->addMessage({
status => 'unread',
subject => $self->get('subject'),