oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use WebGUI::Pluggable::instanciate instead of string eval to load Image::Graph modules. Fixes bug #11898.

Browse source
This commit is contained in:
Colin Kuskie 2010-10-12 11:03:22 -07:00
parent a614d4f230
commit 4b1af3de18
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

1
docs/changelog/7.x.x.txt
View file

@ -6,6 +6,7 @@
- fixed #11773: SQL injection vulnerability in Edit Thing form processing code. - fixed #11773: SQL injection vulnerability in Edit Thing form processing code.
- fixed #11906: Carousel slide height problems - fixed #11906: Carousel slide height problems
- fixed #11900: Request Approval for Version Tag Workflow activity can't select --Continue with this workflow - fixed #11900: Request Approval for Version Tag Workflow activity can't select --Continue with this workflow
- fixed #11898: String eval used in Image::Graph
7.10.2 7.10.2
- fixed #11884: Editing Templates impossible / Code editor not loaded - fixed #11884: Editing Templates impossible / Code editor not loaded

9
lib/WebGUI/Image/Graph.pm
View file

@ -6,6 +6,7 @@ use WebGUI::Image::Palette;
use WebGUI::Image::Font; use WebGUI::Image::Font;
use List::Util; use List::Util;
use WebGUI::Utility; use WebGUI::Utility;
use WebGUI::Pluggable;
our @ISA = qw(WebGUI::Image); our @ISA = qw(WebGUI::Image);
@ -545,11 +546,9 @@ sub load {
my $session = shift; my $session = shift;
my $namespace = shift; my $namespace = shift;
my $cmd = "use $namespace"; my $plugin = eval {
eval($cmd); WebGUI::Pluggable::instanciate($namespace, 'new', [$session, ]);
};
$cmd = $namespace.'->new($session)';
my $plugin = eval($cmd);
return $plugin; return $plugin;
} }