oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Allow certain fields in Ad and AdSpace to be cleared. Add tests

Browse source 
to verify that it works.
This commit is contained in:
Colin Kuskie 2008-08-20 16:40:55 +00:00
parent 268a3ef3f0
commit 4bcf390ce9
5 changed files with 55 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

13
lib/WebGUI/AdSpace.pm
View file

@ -333,10 +333,15 @@ The height, in pixels, of this ad space.
sub set {
my $self = shift;
my $properties = shift || {};
##create requires a name, default will never be used
$self->{_properties}{name} = $properties->{name} || $self->{_properties}{name} || "Unnamed";
$self->{_properties}{title} = $properties->{title} || $self->{_properties}{title} || "Untitled";
$self->{_properties}{description} = $properties->{description} || $self->{_properties}{description};
##create requires a name, default will never be used. This prevents the name from being
##erased
$self->{_properties}{name} = $properties->{name} || $self->{_properties}{name} || "Unnamed";
##Allow title and description to be cleared
$self->{_properties}{title} = exists $properties->{title} ? $properties->{title}
: $self->{_properties}{title} || "Untitled";
$self->{_properties}{description} = exists $properties->{description} ? $properties->{description} : $self->{_properties}{description};
$self->{_properties}{costPerImpression} = exists $properties->{costPerImpression} ? $properties->{costPerImpression} : $self->{_properties}{costPerImpression};
$self->{_properties}{costPerClick} = exists $properties->{costPerClick} ? $properties->{costPerClick} : $self->{_properties}{costPerClick};
$self->{_properties}{minimumImpressions} = $properties->{minimumImpressions} || $self->{_properties}{minimumImpressions};

3
lib/WebGUI/AdSpace/Ad.pm
View file

@ -247,7 +247,8 @@ sub set {
$self->{_properties}{title} = $properties->{title} || $self->{_properties}{title} || "Untitled";
$self->{_properties}{clicksBought} = $properties->{clicksBought} || $self->{_properties}{clicksBought};
$self->{_properties}{impressionsBought} = $properties->{impressionsBought} || $self->{_properties}{impressionsBought};
$self->{_properties}{url} = $properties->{url} || $self->{_properties}{url};
$self->{_properties}{url} = exists $properties->{url} ? $properties->{url} : $self->{_properties}{url};
$self->{_properties}{adText} = exists $properties->{adText} ? $properties->{adText} : $self->{_properties}{adText};
$self->{_properties}{adText} = $properties->{adText} || $self->{_properties}{adText};
$self->{_properties}{storageId} = $properties->{storageId} || $self->{_properties}{storageId};
$self->{_properties}{richMedia} = $properties->{richMedia} || $self->{_properties}{richMedia};