oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix for bug # 10131 - WebGUI::Form::Integer returns 0 even if inbound value is empty, had to code a workaround (rather than change WebGUI::Form::Integer, which could have downstream effects)

Browse source
This commit is contained in:
Tom Suchy 2009-04-16 03:41:41 +00:00
parent 2f5fc2f4e1
commit 4e013703f4
1 changed files with 25 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

25
lib/WebGUI/Asset/Wobject/DataForm.pm
View file

@ -1532,11 +1532,36 @@ sub www_process {
my $default = $field->{defaultValue};
WebGUI::Macro::process($self->session, \$default);
my $value = $entry->field( $field->{name} ) || $default;
#
# tomsuchy -- 2009-04-14 -- bug # 10131
# WebGUI::Form::Integer::getValue() returns 0 even if no number is passed in.
# Not really a suitable default if we want to trigger the error message
#
if ($field->{status} eq "required" || $field->{status} eq "editable") {
#
# tomsuchy -- 2009-04-14 -- bug # 10131
# get the raw value (by sending field type as blank)
#
my $rawValue = $session->form->process($field->{name}, '');
$value = $session->form->process($field->{name}, $field->{type}, undef, {
defaultValue => $default,
value => $value,
});
#
# tomsuchy -- 2009-04-14 -- bug # 10131
# this is a hack, but it's better than changing the default getValue() of Integer, which
# could have massive effects downstream in other uses.
# All it does is set the value to the rawValue, IF it's an int, the raw is blank, and the val is 0
#
if(($field->{type} =~ /integer/i) && defined($rawValue) && ($rawValue eq '') && ($value eq "0")) {
$value = $rawValue;
}
WebGUI::Macro::filter(\$value);
}
if ($field->{status} eq "required" && (! defined($value) || $value =~ /^\s*$/)) {