Forbid pasting content below a shortcut, to prevent loops on purge and other operations. Fixes bug #11855.

lib/WebGUI/Asset/Shortcut.pm

@@ -786,6 +786,19 @@ sub notLinked {
 
 #-------------------------------------------------------------------
 
+=head2 paste ( )
+
+Pasting assets under a Shortcut can cause lots of problems, including infinite loops
+for operations like paste, and purge.
+
+=cut
+
+sub paste {
+    return 0;
+}
+
+#-------------------------------------------------------------------
+
 =head2 prepareView ( )
 
 See WebGUI::Asset::prepareView() for details.  Extends the base class to call prepareView

lib/WebGUI/AssetClipboard.pm

@@ -214,7 +214,7 @@ sub paste {
 	return 0 unless ($self->state eq "published");
     return 0 unless ($pastedAsset->canPaste());  ##Allow pasted assets to have a say about pasting.
 
-    # Don't allow a shortcut to create an endless loop
+    ##Do not paste a shortcut immediately below the original asset
 	return 0 if ($pastedAsset->isa("WebGUI::Asset::Shortcut") && $pastedAsset->shortcutToAssetId eq $self->getId);
     my $i18n=WebGUI::International->new($session, 'Asset');
     $outputSub->(sprintf $i18n->get('pasting %s'), $pastedAsset->getTitle) if defined $outputSub;