oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

optimize the SQL query for getting tax rates

Browse source
This commit is contained in:
Colin Kuskie 2008-03-06 23:41:16 +00:00
parent d956e58bd7
commit 50fc494759
2 changed files with 6 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

18
lib/WebGUI/Shop/Tax.pm
View file

@ -222,20 +222,12 @@ sub getTaxRates {
my $code = $address->get('code'); my $code = $address->get('code');
my $result = $self->session->db->buildArrayRef( my $result = $self->session->db->buildArrayRef(
q{ q{
select taxRate from tax where select taxRate from tax where country=?
(country=? and state='' and city='' and code='') and (state='' or state=?)
OR (country=? and state=? and city='' and code='') and (city='' or city=?)
OR (country=? and state=? and city=? and code='') and (code='' or code=?)
OR (country=? and state=? and city='' and code=? )
OR (country=? and state=? and city=? and code=? )
}, },
[ [ $country, $state, $city, $code, ]);
$country,
$country, $state,
$country, $state, $city,
$country, $state, $code,
$country, $state, $city, $code,
]);
return $result; return $result;
} }

2
t/Shop/Tax.t
View file

@ -439,7 +439,7 @@ cmp_deeply(
cmp_deeply( cmp_deeply(
$taxer->getTaxRates($taxFreeAddress), $taxer->getTaxRates($taxFreeAddress),
[0.0], [0,0],
'getTaxRates: return correct data for a state with no tax data' 'getTaxRates: return correct data for a state with no tax data'
); );