From 55237e3e821103163d5992a5e4f62b2f23b82bf4 Mon Sep 17 00:00:00 2001 From: Colin Kuskie Date: Fri, 13 Jun 2008 00:05:05 +0000 Subject: [PATCH] fix the label test to handle not explicit i18n namespace in new --- .../Perl/Critic/Policy/WebGUI/NoIllegalI18NLabels.pm | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/t/lib/Perl/Critic/Policy/WebGUI/NoIllegalI18NLabels.pm b/t/lib/Perl/Critic/Policy/WebGUI/NoIllegalI18NLabels.pm index a5f589eb3..18abea7a5 100644 --- a/t/lib/Perl/Critic/Policy/WebGUI/NoIllegalI18NLabels.pm +++ b/t/lib/Perl/Critic/Policy/WebGUI/NoIllegalI18NLabels.pm @@ -73,14 +73,19 @@ sub violates { return unless $class eq 'WebGUI::International'; my $symbol_name = _get_symbol_name($class); + return unless $symbol_name; ##It's an i18n object, see if a default namespace was passed in. my $arg_list = $elem->snext_sibling; return unless ref $arg_list eq 'PPI::Structure::List'; my @arguments = _get_args($arg_list); - my $namespace = $arguments[1]->[0]; - return unless $namespace; ##This can be a namespace in a variable. - $namespace = $namespace->string || 'WebGUI'; + my $namespace; + if ($arguments[1]) { + $namespace = $arguments[1]->[0]->string; + } + else { + $namespace = 'WebGUI'; + } $self->{_i18n_objects}->{$symbol_name} = $namespace; return; }