From 568a02a6af4866192c7b16893b5bdbe3e8051bc7 Mon Sep 17 00:00:00 2001 From: Colin Kuskie Date: Thu, 2 Nov 2006 00:08:12 +0000 Subject: [PATCH] This is as good as it's going to get. In order to push the coverage up any higher, we'd have to reverse engineer the Apache::Cookie module, figure out what it's doing to the request. --- t/Session/Http.t | 34 +++++++++++++++++++++++++++++++++- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/t/Session/Http.t b/t/Session/Http.t index a2e6eb46a..b6a27bd36 100644 --- a/t/Session/Http.t +++ b/t/Session/Http.t @@ -22,7 +22,7 @@ use DateTime::Format::Strptime; use Test::More; # increment this value for each test you create use Test::Deep; -my $num_tests = 60; +my $num_tests = 71; plan tests => $num_tests; @@ -178,6 +178,10 @@ isnt($http->setRedirect('/here/now'), undef, 'setRedirect: does not return undef # #################################################### +##Force settings +my $origPreventProxyCache = $session->setting->get('preventProxyCache'); +$session->setting->set('preventProxyCache', 0); + ##Clear request object for next two tests $session->{_request} = undef; @@ -337,6 +341,33 @@ ok(! exists $request->headers_out->fetch->{'Expires'}, 'sendHeaders, cacheContro is($request->headers_out->fetch->{'Cache-Control'}, "max-age=250", 'sendHeaders, cacheControl=250, user=visitor, HTTP 5.5: header Expires does not exist'); is($request->no_cache, undef, 'sendHeaders, cacheControl=250, user=visitor, HTTP 5.5: no_cache undefined'); +##Clear request object to run a new set of requests +$request = WebGUI::PseudoRequest->new(); +$session->{_request} = $request; +$request->protocol('HTTP 5.5'); +$http->setNoHeader(0); +$http->setCacheControl('none'); +$http->sendHeader(); + +##Boolean test here +ok(! exists $request->headers_out->fetch->{'Expires'}, 'sendHeaders, cacheControl=none, user=visitor, HTTP 5.5: header Expires does not exist'); +is($request->headers_out->fetch->{'Cache-Control'}, "private", 'sendHeaders, cacheControl=none, user=visitor, HTTP 5.5: header Cache-Control=private'); +is($request->no_cache, 1, 'sendHeaders, cacheControl=none, user=visitor, HTTP 5.5: no_cache=1'); + +##Clear request object to run a new set of requests +$request = WebGUI::PseudoRequest->new(); +$session->{_request} = $request; +$request->protocol('HTTP 5.5'); +$http->setNoHeader(0); +$http->setCacheControl('80'); +$session->setting->set('preventProxyCache', 1); +$http->sendHeader(); + +##Boolean test here +ok(! exists $request->headers_out->fetch->{'Expires'}, 'sendHeaders, cacheControl=none, user=visitor, HTTP 5.5: header Expires does not exist'); +is($request->headers_out->fetch->{'Cache-Control'}, "private", 'sendHeaders, cacheControl=80, preventProxyCache=1, user=visitor, HTTP 5.5: header Cache-Control=private'); +is($request->no_cache, 1, 'sendHeaders, cacheControl=none, preventProxyCache=1, user=visitor, HTTP 5.5: no_cache=1'); + #################################################### # # Utility functions @@ -367,4 +398,5 @@ sub deltaHttpTimes { END { + $session->setting->set('preventProxyCache', $origPreventProxyCache); }