oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

add a input validation check and test for Tax->calculate

Browse source
This commit is contained in:
Colin Kuskie 2008-03-01 21:22:53 +00:00
parent 9d377193d3
commit 5946fd5476
2 changed files with 15 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

3
lib/WebGUI/Shop/Tax.pm
View file

@ -87,10 +87,9 @@ Calculate the tax for the contents of the cart.
sub calculate { sub calculate {
my $self = shift; my $self = shift;
my $cart = shift; my $cart = shift;
WebGUI::Error::InvalidParam->throw(error => 'Must pass in a WebGUI::Shop::Cart object') WebGUI::Error::InvalidParam->throw(error => 'Must pass in a WebGUI::Shop::Cart object')
unless ref($cart) eq 'WebGUI::Shop::Cart'; unless ref($cart) eq 'WebGUI::Shop::Cart';
return $id; return;
} }
#------------------------------------------------------------------- #-------------------------------------------------------------------

21
t/Shop/Tax.t
View file

@ -31,7 +31,7 @@ my $session = WebGUI::Test->session;
#---------------------------------------------------------------------------- #----------------------------------------------------------------------------
# Tests # Tests
my $tests = 62; my $tests = 64;
plan tests => 1 + $tests; plan tests => 1 + $tests;
#---------------------------------------------------------------------------- #----------------------------------------------------------------------------
@ -366,6 +366,19 @@ cmp_deeply(
'importTaxData: error handling for file that that cannot be read', 'importTaxData: error handling for file that that cannot be read',
); );
#######################################################################
#
# calculate
#
#######################################################################
eval { $taxer->calculate(); };
$e = Exception::Class->caught();
isa_ok($e, 'WebGUI::Error::InvalidParam', 'calculate: error handling for not sending a cart');
is($e->error, 'Must pass in a WebGUI::Shop::Cart object', 'calculate: error handling for not sending a cart');
##Build a cart, add some Donation SKUs to it. Set one to be taxable.
} }
sub _grabTaxData { sub _grabTaxData {
@ -378,12 +391,6 @@ sub _grabTaxData {
return @taxData; return @taxData;
} }
#######################################################################
#
# calculate
#
#######################################################################
#---------------------------------------------------------------------------- #----------------------------------------------------------------------------
# Cleanup # Cleanup
END { END {