From 5ddc16865901806582c6e4986a9e26c4cf82ac73 Mon Sep 17 00:00:00 2001 From: Colin Kuskie Date: Fri, 30 Jun 2006 20:41:33 +0000 Subject: [PATCH] Fix a typo in WSClient which prevented it from adding/editing assets. Make the whitespace test give some context to its failures. Fix a buglet in the label test. --- docs/changelog/7.x.x.txt | 1 + lib/WebGUI/Asset/Wobject/WSClient.pm | 2 +- t/Whitespace.t | 5 ++++- t/i18n/label.t | 2 +- 4 files changed, 7 insertions(+), 3 deletions(-) diff --git a/docs/changelog/7.x.x.txt b/docs/changelog/7.x.x.txt index 5f23326f9..047536cbb 100644 --- a/docs/changelog/7.x.x.txt +++ b/docs/changelog/7.x.x.txt @@ -18,4 +18,5 @@ - fix: User/Group problem - fix: Edit LDAP Connection - fix: SQL Report w/ pagination and nested queries + - fix: Unable to add Web Services Client diff --git a/lib/WebGUI/Asset/Wobject/WSClient.pm b/lib/WebGUI/Asset/Wobject/WSClient.pm index 801559fee..c13ec4de9 100644 --- a/lib/WebGUI/Asset/Wobject/WSClient.pm +++ b/lib/WebGUI/Asset/Wobject/WSClient.pm @@ -118,7 +118,7 @@ sub getEditForm { -name => 'templateId', -value => $self->getValue('templateId'), -namespace => "WSClient", - -label => WebG$i18n->get(72), + -label => $i18n->get(72), -hoverHelp => $i18n->get('72 description'), ); $tabform->getTab("display")->yesNo ( diff --git a/t/Whitespace.t b/t/Whitespace.t index 67b70a53c..95378ccf8 100644 --- a/t/Whitespace.t +++ b/t/Whitespace.t @@ -64,7 +64,10 @@ sub checkContent { foreach my $line (@content) { chomp $line; my $isPodWord = ($line =~ m/^=/); - return 1 if ($isPodWord && !$podAllowed); + if ($isPodWord && !$podAllowed) { + diag $line; + return 1; + } # POD is allowed on next line if current line is empty $podAllowed = ($line eq ''); } diff --git a/t/i18n/label.t b/t/i18n/label.t index 7235cc57f..6d14b362d 100644 --- a/t/i18n/label.t +++ b/t/i18n/label.t @@ -227,7 +227,7 @@ sub getHelpLabels { sub getHelpVariables { my ($variables) = @_; ##An arrayref of variables, possibly with nested variables in loops - my $tmplVars; + my $tmplVars = []; foreach my $var ( @{ $variables } ) { if ( exists $var->{variables} ) { push @{ $tmplVars }, @{ getHelpVariables($var->{variables}) };