Macro test maintenance.

This commit is contained in:
Colin Kuskie 2009-10-31 12:05:07 -07:00
parent 058704d027
commit 5ea3f02520
6 changed files with 20 additions and 91 deletions

View file

@ -14,6 +14,7 @@ use lib "$FindBin::Bin/../lib";
use WebGUI::Test;
use WebGUI::Session;
use WebGUI::Macro::GroupAdd;
use Data::Dumper;
use Test::More; # increment this value for each test you create
@ -22,7 +23,7 @@ use HTML::TokeParser;
my $session = WebGUI::Test->session;
my $homeAsset = WebGUI::Asset->getDefault($session);
my ($versionTag, $template, $groups, $users) = setupTest($session, $homeAsset);
my ($template, $groups, $users) = setupTest($session, $homeAsset);
my @testSets = (
{
@ -118,17 +119,8 @@ foreach my $testSet (@testSets) {
$numTests += 1 + ($testSet->{empty} == 0);
}
$numTests += 1; #For the use_ok
plan tests => $numTests;
my $macro = 'WebGUI::Macro::GroupAdd';
my $loaded = use_ok($macro);
SKIP: {
skip "Unable to load $macro", $numTests-1 unless $loaded;
foreach my $testSet (@testSets) {
$session->user({ userId => $testSet->{userId} });
my $output = WebGUI::Macro::GroupAdd::process($session,
@ -144,8 +136,6 @@ foreach my $testSet (@testSets) {
}
}
}
sub setupTest {
my ($session, $defaultNode) = @_;
my @groups;
@ -156,13 +146,13 @@ sub setupTest {
$groups[1] = WebGUI::Group->new($session, "new");
$groups[1]->name('Regular Old Group');
$groups[1]->autoAdd(0);
WebGUI::Test->groupsToDelete(@groups);
addToCleanup(@groups);
##Three users. One in each group and one with no group membership
my @users = map { WebGUI::User->new($session, "new") } 0..2;
$users[0]->addToGroups([$groups[0]->getId]);
$users[1]->addToGroups([$groups[1]->getId]);
WebGUI::Test->usersToDelete(@users);
addToCleanup(@users);
my $versionTag = WebGUI::VersionTag->getWorking($session);
$versionTag->set({name=>"GroupAdd test"});
@ -178,8 +168,9 @@ sub setupTest {
};
my $asset = $defaultNode->addChild($properties, $properties->{id});
$versionTag->commit;
addToCleanup($versionTag);
return $versionTag, $asset, \@groups, \@users;
return $asset, \@groups, \@users;
}
sub simpleHTMLParser {
@ -201,9 +192,3 @@ sub simpleTextParser {
return ($url, $label);
}
END { ##Clean-up after yourself, always
if (defined $versionTag and ref $versionTag eq 'WebGUI::VersionTag') {
$versionTag->rollback;
}
}