From 5ff871f2d5a816b081d24b67284700ec574e5d1c Mon Sep 17 00:00:00 2001 From: Colin Kuskie Date: Tue, 5 Oct 2010 16:03:33 -0700 Subject: [PATCH] Fix loose calls to $form->param('key') --- lib/WebGUI/Asset.pm | 2 +- lib/WebGUI/Asset/Event.pm | 2 +- lib/WebGUI/Asset/Wobject/EventManagementSystem.pm | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/WebGUI/Asset.pm b/lib/WebGUI/Asset.pm index f111c8450..34194743b 100644 --- a/lib/WebGUI/Asset.pm +++ b/lib/WebGUI/Asset.pm @@ -2842,7 +2842,7 @@ sub www_changeUrl { my $i18n = WebGUI::International->new($self->session, "Asset"); my $f = WebGUI::HTMLForm->new($self->session, action=>$self->getUrl); $f->hidden(name=>"func", value=>"changeUrlConfirm"); - $f->hidden(name=>"proceed", value=>$self->session->form->param("proceed")); + $f->hidden(name=>"proceed", value=>scalar($self->session->form->param("proceed"))); $f->text(name=>"url", value=>$self->get('url'), label=>$i18n->get("104"), hoverHelp=>$i18n->get('104 description')); $f->yesNo(name=>"confirm", value=>0, label=>$i18n->get("confirm change"), hoverHelp=>$i18n->get("confirm change url message"), subtext=>'
'.$i18n->get("confirm change url message")); $f->submit; diff --git a/lib/WebGUI/Asset/Event.pm b/lib/WebGUI/Asset/Event.pm index a66a56c17..8c8b42ef6 100644 --- a/lib/WebGUI/Asset/Event.pm +++ b/lib/WebGUI/Asset/Event.pm @@ -1399,7 +1399,7 @@ sub processPropertiesFromFormPost { my $assetId = $self->get('assetId'); my $revisionDate = $self->get('revisionDate'); - $session->db->write("UPDATE Event SET sequenceNumber =? WHERE assetId = ? AND revisionDate =?",[($form->param('sequenceNumber') || $top_val), $assetId, $revisionDate]); + $session->db->write("UPDATE Event SET sequenceNumber =? WHERE assetId = ? AND revisionDate =?",[(scalar($form->param('sequenceNumber')) || $top_val), $assetId, $revisionDate]); # Pre-process Related Links and manage changes diff --git a/lib/WebGUI/Asset/Wobject/EventManagementSystem.pm b/lib/WebGUI/Asset/Wobject/EventManagementSystem.pm index 560bf2887..81ef87a67 100644 --- a/lib/WebGUI/Asset/Wobject/EventManagementSystem.pm +++ b/lib/WebGUI/Asset/Wobject/EventManagementSystem.pm @@ -2016,7 +2016,7 @@ sub www_importEvents { -label => $i18n->get('ignore first line'), -name => 'ignore_first_line', -hoverHelp => $i18n->get('import hoverhelp first line'), - -defaultValue => $form->param('ignore_first_line'), + -defaultValue => scalar $form->param('ignore_first_line'), ); # create the std & meta fields part of the form @@ -2033,7 +2033,7 @@ sub www_importEvents { name => 'fieldsToImport', defaultValue => \@defaultImportableFields, options => \%importableFields, - value => $form->get('fieldsToImport'), + value => scalar $form->get('fieldsToImport'), ); $f->submit(-value=>$i18n->get('import events'));