more bug fixes

lib/WebGUI/Asset.pm

@@ -550,7 +550,7 @@ sub getEditForm {
                 -value=>$self->get("newWindow"),
                 -label=>$i18n->get(940),
 		-hoverHelp=>$i18n->get('940 description'),
-                -uiLevel=>6
+                -uiLevel=>9
                 );
 	$tabform->addTab("security",$i18n->get(107),6);
         $tabform->getTab("security")->yesNo(

lib/WebGUI/AssetBranch.pm

@@ -128,7 +128,7 @@ sub www_editBranch {
                 -name=>"newWindow",
                 -value=>$self->get("newWindow"),
                 -label=>$i18n->get(940),
-		-hoverHelp=>$i18n->get('940 description',"Asset"),
+		-hoverHelp=>$i18n->get('940 description'),
                 -uiLevel=>6,
 		-subtext=>'<br />'.$i18n->get("change").' '.WebGUI::Form::yesNo($self->session,{name=>"change_newWindow"})
                 );

lib/WebGUI/VersionTag.pm

@@ -96,7 +96,7 @@ sub commit {
 		$asset->commit;
 	}
 	$self->{_data}{isCommitted} = 1;
-	$self->{_data}{committedBy} = $self->session->user->userId;
+	$self->{_data}{committedBy} = $self->session->user->userId unless ($self->{_data}{committedBy});
 	$self->{_data}{commitDate} = $self->session->datetime->time();
 	$self->session->db->setRow("assetVersionTag", "tagId", $self->{_data});
 	$self->clearWorking;
@@ -258,6 +258,7 @@ sub requestCommit {
 		methodName=>"new",
 		parameters=>$self->getId
 		});	
+	$self->{_data}{committedBy} = $self->session->user->userId;
 	$self->{_data}{workflowInstanceId} = $instance->getId;
 	$self->session->db->setRow("assetVersionTag","tagId",$self->{_data});
 }

lib/WebGUI/i18n/English/Asset.pm

@@ -260,10 +260,10 @@ a URL will be made from the parent's URL and the <b>Menu Title</b>.<br />
         },
 
         '940 description' => {
-                message => q|<p>Select yes to open this asset in a new window.<br />
-<i>UI level: 6</i>
+                message => q|<p>Select yes to open this asset in a new window. Note that there are potentially many problems with this. It may not work in some navigations, or if the user turns off Javascript, or it may be blocked by some pop-up blockers. Use this feature with care.<br />
+<i>UI level: 9</i>
 </p>|,
-                lastUpdated => 1127426196,
+                lastUpdated => 1143218834,
         },
 
         'encrypt page description' => {

lib/WebGUI/i18n/English/WebGUI.pm

@@ -373,11 +373,6 @@ Be aware that any database links you create here will be available to all conten
 		lastUpdated => 1056151382
 	},
 
-	'940' => {
-		message => q|Open in new window?|,
-		lastUpdated => 1050438829
-	},
-
 	'43' => {
 		message => q|Are you certain that you wish to delete this content?|,
 		lastUpdated => 1031514049