bug hunting

This commit is contained in:
Nik Ogura 2007-05-02 22:06:49 +00:00
parent 5387964567
commit 63848995ee

View file

@ -183,15 +183,16 @@ sub execute {
$from =~ /(\S+\@\S+)/; $from =~ /(\S+\@\S+)/;
my $user = WebGUI::User->newByEmail($self->session, $from); my $user = WebGUI::User->newByEmail($self->session, $from);
unless (defined $user) { unless (defined $user) {
my $send = WebGUI::Mail::Send->create($self->session, { $user = WebGUI::User->new($self->session, undef);
to=>$message->{from}, # my $send = WebGUI::Mail::Send->create($self->session, {
inReplyTo=>$message->{messageId}, # to=>$message->{from},
subject=>$cs->get("mailPrefix").$i18n->get("rejected")." ".$self->{subject}, # inReplyTo=>$message->{messageId},
from=>$cs->get("mailAddress") # subject=>$cs->get("mailPrefix").$i18n->get("rejected")." ".$self->{subject},
}); # from=>$cs->get("mailAddress")
$send->addText($i18n->get("rejected because no user account")); # });
$send->send; # $send->addText($i18n->get("rejected because no user account"));
next; # $send->send;
# next;
} }
my $post = undef; my $post = undef;
if ($message->{inReplyTo}) { if ($message->{inReplyTo}) {
@ -202,11 +203,13 @@ sub execute {
if (defined $post && $cs->get("allowReplies") && $user->isInGroup($cs->get("postGroupId")) && (!$cs->get("requireSubscriptionForEmailPosting") || $user->isInGroup($cs->get("subscriptionGroupId")) || $user->isInGroup($post->get("subscriptionGroupId")))) { if (defined $post && $cs->get("allowReplies") && $user->isInGroup($cs->get("postGroupId")) && (!$cs->get("requireSubscriptionForEmailPosting") || $user->isInGroup($cs->get("subscriptionGroupId")) || $user->isInGroup($post->get("subscriptionGroupId")))) {
$self->addPost($post, $message, $user, $cs->get("mailPrefix")); $self->addPost($post, $message, $user, $cs->get("mailPrefix"));
#subscribe poster to thread if set to autosubscribe, and they're not already
if ($cs->get("autoSubscribeToThread") && !($user->isInGroup($cs->get("subscriptionGroupId")) || $user->isInGroup($post->get("subscriptionGroupId")))) { if ($cs->get("autoSubscribeToThread") && !($user->isInGroup($cs->get("subscriptionGroupId")) || $user->isInGroup($post->get("subscriptionGroupId")))) {
$user->addToGroups([$post->getThread->get("subscriptionGroupId")]); $user->addToGroups([$post->getThread->get("subscriptionGroupId")]);
} }
} elsif ($user->isInGroup($cs->get("postGroupId")) && (!$cs->get("requireSubscriptionForEmailPosting") || $user->isInGroup($cs->get("subscriptionGroupId")))) { } elsif ($user->isInGroup($cs->get("postGroupId")) && (!$cs->get("requireSubscriptionForEmailPosting") || $user->isInGroup($cs->get("subscriptionGroupId")))) {
my $thread = $self->addPost($cs, $message, $user, $cs->get("mailPrefix")); my $thread = $self->addPost($cs, $message, $user, $cs->get("mailPrefix"));
#subscribe poster to thread if set to autosubscribe, and they're not already
if ($cs->get("autoSubscribeToThread") && !$user->isInGroup($cs->get("subscriptionGroupId"))) { if ($cs->get("autoSubscribeToThread") && !$user->isInGroup($cs->get("subscriptionGroupId"))) {
$user->addToGroups([$thread->get("subscriptionGroupId")]); $user->addToGroups([$thread->get("subscriptionGroupId")]);
} }
@ -217,7 +220,8 @@ sub execute {
subject=>$cs->get("mailPrefix").$i18n->get("rejected")." ".$self->{subject}, subject=>$cs->get("mailPrefix").$i18n->get("rejected")." ".$self->{subject},
from=>$cs->get("mailAddress") from=>$cs->get("mailAddress")
}); });
$send->addText($i18n->get("rejected because not allowed")); my $cslevel = $cs->get("postGroupId");
$send->addText($i18n->get("rejected because not allowed").$cslevel);
$send->send; $send->send;
} }
# just in case there are a lot of messages, we should release after a minutes worth of retrieving # just in case there are a lot of messages, we should release after a minutes worth of retrieving