oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Moved ResponseJSON data hash to private variable, for security and

Browse source 
consistency with SurveyJSON

Added some more accessors/mutators, and param validation
This commit is contained in:
Patrick Donelan 2009-02-03 08:32:40 +00:00
parent 17dbf7fa66
commit 66a2adcbe5
3 changed files with 47 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

6
lib/WebGUI/Asset/Wobject/Survey/SurveyJSON.pm
View file

@ -76,7 +76,7 @@ a JSON hash made up of "survey" and "sections" keys.
sub new {
my $class = shift;
my ($session, $json) = validate_pos(@_, {isa => 'WebGUI::Session' }, { type => SCALAR, optional => 1});
my ($session, $json) = validate_pos(@_, {isa => 'WebGUI::Session' }, { type => SCALAR | UNDEF, optional => 1});
# Load json object if given..
my $jsonData = $json ? from_json($json) : {};
@ -874,7 +874,7 @@ The question type determines how many answers to add and what answer text (if an
sub updateQuestionAnswers {
my $self = shift;
my ($address, $type) = validate_pos(@_, { type => ARRAYREF }, { type => SCALAR, optional => 1});
my ($address, $type) = validate_pos(@_, { type => ARRAYREF }, { type => SCALAR | UNDEF, optional => 1});
# Make a private copy of the $address arrayref that we can use locally
# when updating answer text without causing side-effects for the caller's $address
@ -1185,7 +1185,7 @@ See L<"Address Parameter">.
sub questions {
my $self = shift;
my ($address) = validate_pos(@_, { type => ARRAYREF});
my ($address) = validate_pos(@_, { type => ARRAYREF, optional => 1});
return $self->sections->[ $address->[0] ]->{questions};
}