From 66db563c390ad4d7bcd6cba9fd78528a2966fb6b Mon Sep 17 00:00:00 2001
From: JT Smith <jt@plainblack.com>
Date: Thu, 24 Sep 2009 23:12:20 -0500
Subject: [PATCH] basics all tested

---
 lib/WebGUI/Cache.pm | 17 +++--------------
 t/Cache.t           |  9 +++++++--
 2 files changed, 10 insertions(+), 16 deletions(-)

diff --git a/lib/WebGUI/Cache.pm b/lib/WebGUI/Cache.pm
index d84598723..2d932d259 100644
--- a/lib/WebGUI/Cache.pm
+++ b/lib/WebGUI/Cache.pm
@@ -245,8 +245,8 @@ A time in seconds for the cache to exist. When you override default it to 60 sec
 sub set {
     my ($self, $name, $value, $ttl) = @_;
     $ttl ||= 60;
-    $value = Storable::nfreeze(\(scalar $value)); # Storable doesn't like non-reference arguments, so we wrap it in a scalar ref.
-    Memcached::libmemcached::memcached_set($self->getMemcached, $self->parseKey($name), $value, $ttl);
+    my $frozenValue = Storable::nfreeze(\(scalar $value)); # Storable doesn't like non-reference arguments, so we wrap it in a scalar ref.
+    Memcached::libmemcached::memcached_set($self->getMemcached, $self->parseKey($name), $frozenValue, $ttl);
     return $value;
 }
 
@@ -284,20 +284,9 @@ sub setByHttp {
         # show throw exception
         return undef;
     }
-    return $self->set($response->decoded_content, $ttl);
+    return $self->set($name, $response->decoded_content, $ttl);
 }
 
-#-------------------------------------------------------------------
-
-=head2 stats ( )
-
-Return a formatted text string describing cache usage. Must be overridden.
-
-=cut
-
-sub stats {
-
-}
 
 
 1;
diff --git a/t/Cache.t b/t/Cache.t
index 0de17d40c..2cf4ea095 100644
--- a/t/Cache.t
+++ b/t/Cache.t
@@ -29,7 +29,7 @@ my $session         = WebGUI::Test->session;
 #----------------------------------------------------------------------------
 # Tests
 
-plan tests => 7;        # Increment this number for each test you create
+plan tests => 10;        # Increment this number for each test you create
 
 #----------------------------------------------------------------------------
 
@@ -44,7 +44,12 @@ is($cache->get(["andy", "dufresne"]), "Prisoner", "set/get composite");
 my ($a, $b) = @{$cache->mget(["Shawshank",["andy", "dufresne"]])};
 is($a, "Prison", "mget first value");
 is($b, "Prisoner", "mget second value");
-
+$cache->delete("Shawshank");
+is($cache->get("Shawshank"), undef, 'delete');
+$cache->flush;
+is($cache->get(["andy", "dufresne"]), undef, 'flush');
+$cache->setByHttp("google", "http://www.google.com/");
+cmp_ok($cache->get("google"), 'ne', '', 'setByHttp');
 
 
 #----------------------------------------------------------------------------