oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Started deprecating WebGUI::Session::Http

Browse source
This commit is contained in:
Patrick Donelan 2010-04-06 20:02:33 -04:00
parent 72017cf83f
commit 68bbca1808
4 changed files with 20 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
TODO Normal file
View file

@ -0,0 +1,9 @@
TODO
* Deprecate WebGUI::Session::HTTP - replace with WebGUI::Request/Response
* Turn logger into $self->request->env->{'psgi.errors'}->print(join '', @stuff);
DONE
* $session->request is now a Plack::Request object
* serverObject gone from WebGUI::Session::open()
* WebGUI::authen API changed
* urlHandler API changed - no longer gets server, config

2
lib/WebGUI.pm
View file

@ -162,8 +162,8 @@ sub dispatch {
}
}
}
$session->close;
return $session->response->finalize;
}

2
lib/WebGUI/Session.pm
View file

@ -460,7 +460,7 @@ sub open {
bless $self , $class;
$self->{_request} = $request if defined $request;
$self->{_response} = $request->new_response( 200 ) if defined $request;
my $sessionId = shift || $self->http->getCookies->{$config->getCookieName} || $self->id->generate;
my $sessionId = shift || $request->cookies->{$config->getCookieName} || $self->id->generate;
$sessionId = $self->id->generate unless $self->id->valid($sessionId);
my $noFuss = shift;
$self->{_var} = WebGUI::Session::Var->new($self,$sessionId, $noFuss);

11
lib/WebGUI/Session/Http.pm
View file

@ -18,6 +18,12 @@ package WebGUI::Session::Http;
use strict;
use WebGUI::Utility;
sub _deprecated {
my $alt = shift;
my $method = (caller(1))[3];
Carp::carp("$method is deprecated. Use 'WebGUI::$alt' instead.");
}
=head1 NAME
Package WebGUI::Session::Http
@ -91,7 +97,8 @@ Retrieves the cookies from the HTTP header and returns a hash reference containi
sub getCookies {
my $self = shift;
return $self->session->request ? $self->session->request->cookies : {};
_deprecated('Request::cookies');
return $self->session->request->cookies;
}
@ -264,7 +271,7 @@ sub sendHeader {
# send webgui session cookie
my $cookieName = $config->getCookieName;
$self->setCookie($cookieName,$var->getId, $config->getCookieTTL, $config->get("cookieDomain")) unless $var->getId eq $self->getCookies->{$cookieName};
$self->setCookie($cookieName,$var->getId, $config->getCookieTTL, $config->get("cookieDomain")) unless $var->getId eq $request->cookies->{$cookieName};
$self->setNoHeader(1);
my %params;