oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

a few improvements to error reporting/handling

Browse source
This commit is contained in:
Scott Walters 2013-09-26 18:01:41 -05:00
parent da37116d71
commit 69ea5b10ee
2 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/WebGUI/Content/Admin.pm
View file

@ -85,7 +85,7 @@ sub handler {
if ( $session->form->get("op") eq "assetHelper" ) { if ( $session->form->get("op") eq "assetHelper" ) {
# Load and run the requested asset helper www_ method # Load and run the requested asset helper www_ method
my $assetId = $session->form->get('assetId'); my $assetId = $session->form->get('assetId') or $session->log->fatal("no assetId passed to op=assetHelper");
my $asset = WebGUI::Asset->newById( $session, $assetId ); my $asset = WebGUI::Asset->newById( $session, $assetId );
my $helperId = $session->form->get('helperId'); my $helperId = $session->form->get('helperId');

3
lib/WebGUI/Pluggable.pm
View file

@ -17,6 +17,7 @@ package WebGUI::Pluggable;
use strict; use strict;
use Module::Find; use Module::Find;
use Carp qw(croak); use Carp qw(croak);
use Scalar::Util 'blessed';
# Carps should always bypass this package in error reporting # Carps should always bypass this package in error reporting
$Carp::Internal{ __PACKAGE__ }++; $Carp::Internal{ __PACKAGE__ }++;
@ -258,7 +259,7 @@ sub load {
else { else {
$moduleError{$module} = "Could not load $module because $@"; $moduleError{$module} = "Could not load $module because $@";
} }
croak $moduleError{$module}; die $@; # rethrow the error so that we preserve the full stack trace of where the error came from
} }
} }