Fix bad escaping of dashes for element Ids in the Matrix. Fixes bug #11588.

docs/changelog/7.x.x.txt

@@ -2,6 +2,7 @@
  - fixed #11755: New cart does not update shipping methods correctly
  - fixed #11757: Update the USPS International driver for new country names
  - fixed #11753: PayPal Plugin - Shipping not factored into total in paypal
+ - fixed #11588: CMSmatrix - Comparing certain products ends in data errors
 
 7.9.10
  - fixed #11721: spamStopWords not in WebGUI.conf.original

lib/WebGUI/Asset/Wobject/Matrix.pm

@@ -1176,7 +1176,6 @@ sub www_getCompareFormData {
                 $parameter->{value} = $form->process($param);
                 my $attributeId = $param;
                 $attributeId =~ s/^search_//;
-                $attributeId =~ s/_____/-/g;
                 $parameter->{attributeId} = $attributeId;
                 push(@searchParamList,  $db->quote($parameter->{attributeId}) );
                 push(@searchParams,     $parameter);
@@ -1228,20 +1227,17 @@ sub www_getCompareFormData {
                             $checked = 'checked';
                         }
                 }
-                $result->{assetId}  =~ s/-/_____/g;
                 push @results, $result if $checked eq 'checked';
             }
         }
         else {   
             foreach my $result (@{$self->getListings}) {
-                $result->{assetId}  =~ s/-/_____/g;
                 push @results, $result;
             }
         }
     }
     else {
         foreach my $result (@{$self->getListings}) {
-            $result->{assetId}  =~ s/-/_____/g;
             if(WebGUI::Utility::isIn($result->{assetId},@listingIds)){
                 $result->{checked} = 'checked';
             }
@@ -1286,7 +1282,6 @@ sub www_getCompareListData {
     my @responseFields = ("attributeId", "name", "description","fieldType", "checked");
     
     foreach my $listingId (@listingIds){
-        $listingId =~ s/_____/-/g;
         my $listing = WebGUI::Asset::MatrixListing->new($session,$listingId);
         $listing->incrementCounter("compares");
         my $listingId_safe = $listingId;