oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Removed all instances of srand. This is called implicitily by rand and be dangerous if called mulitple times by the same process.

Browse source
This commit is contained in:
Kaleb Murphy 2008-11-10 21:53:30 +00:00
parent 3af1b41542
commit 70a0a422b7
6 changed files with 2 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
docs/changelog/7.x.x.txt
View file

@ -13,7 +13,7 @@
- added: Delete columns from DataTable - added: Delete columns from DataTable
- fixed: Now more than one DataTable can be put on a page - fixed: Now more than one DataTable can be put on a page
- fixed #9002: add a variant in admin product view misses i18n link - fixed #9002: add a variant in admin product view misses i18n link
- fixed #9034: Removed all instances of srand. This is called implicitily by rand and be dangerous if called mulitple times by the same process.
7.6.2 7.6.2
- fixed: not allowed to add calendar events if in can edit group but not can add event group - fixed: not allowed to add calendar events if in can edit group but not can add event group
- sped up lineage changes significantly - sped up lineage changes significantly

2
lib/WebGUI/Asset/Wobject/Survey/ResponseJSON.pm
View file

@ -34,7 +34,7 @@ sub createSurveyOrder{
my $self = shift; my $self = shift;
my $order; my $order;
my $qstarting = 0; my $qstarting = 0;
$self->log('wtf am I faling for');
for(my $s = 0; $s <= $#{$self->survey->sections()}; $s++){ for(my $s = 0; $s <= $#{$self->survey->sections()}; $s++){
#create question order for section #create question order for section
my @qorder; my @qorder;

1
lib/WebGUI/Macro/RandomAssetProxy.pm
View file

@ -41,7 +41,6 @@ sub process {
if (defined $asset) { if (defined $asset) {
my $children = $asset->getLineage(["children"]); my $children = $asset->getLineage(["children"]);
#randomize; #randomize;
srand;
my $randomAssetId = $children->[rand(scalar(@{$children}))]; my $randomAssetId = $children->[rand(scalar(@{$children}))];
my $randomAsset = WebGUI::Asset->newByDynamicClass($session,$randomAssetId); my $randomAsset = WebGUI::Asset->newByDynamicClass($session,$randomAssetId);
if (defined $randomAsset) { if (defined $randomAsset) {

2
lib/WebGUI/Macro/RandomThread.pm
View file

@ -60,8 +60,6 @@ URL of the template to use to display the random thread. Must be a valid URL wit
sub process { sub process {
my $session = shift; my $session = shift;
my ($startURL, $relatives, $templateURL) = @_; my ($startURL, $relatives, $templateURL) = @_;
# Seed the randomizer:
srand;
# Set defaults (default template is set by id later): # Set defaults (default template is set by id later):
$startURL ||= 'home'; $startURL ||= 'home';

1
lib/WebGUI/Session/Id.pm
View file

@ -101,7 +101,6 @@ A reference to the current session.
sub new { sub new {
my $class = shift; my $class = shift;
my $session = shift; my $session = shift;
srand;
bless {_session=>$session}, $class; bless {_session=>$session}, $class;
} }

1
lib/WebGUI/Storage/Image.pm
View file

@ -73,7 +73,6 @@ sub addFileFromCaptcha {
my $self = shift; my $self = shift;
my $error = ""; my $error = "";
my $challenge; my $challenge;
srand;
$challenge.= ('A'..'Z')[rand(26)] foreach (1..6); $challenge.= ('A'..'Z')[rand(26)] foreach (1..6);
my $filename = "captcha.".$self->session->id->generate().".gif"; my $filename = "captcha.".$self->session->id->generate().".gif";
my $image = $graphicsPackage->new(); my $image = $graphicsPackage->new();