From 814845b7f1c32a52d17492ff1ece2fbb203a317d Mon Sep 17 00:00:00 2001 From: Colin Kuskie Date: Tue, 28 Jun 2011 17:16:09 -0700 Subject: [PATCH] Do not call group methods on an undefined value. IOW, do not assume that we got a group. --- docs/changelog/7.x.x.txt | 1 + lib/WebGUI/User.pm | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/changelog/7.x.x.txt b/docs/changelog/7.x.x.txt index 4a45003e0..f4e54623d 100644 --- a/docs/changelog/7.x.x.txt +++ b/docs/changelog/7.x.x.txt @@ -1,4 +1,5 @@ 7.10.20 + - fixed: Do not call group methods on an undefined value. 7.10.19 - fixed #12169: extras uploads symlink export diff --git a/lib/WebGUI/User.pm b/lib/WebGUI/User.pm index 1447dfab8..09a7820e3 100644 --- a/lib/WebGUI/User.pm +++ b/lib/WebGUI/User.pm @@ -684,8 +684,9 @@ sub getGroupIdsRecursive { my $self = shift; my $groupingIds = $self->getGroups( "withoutExpired" ); my %groupIds = map { $_ => 1 } @{ $groupingIds }; - while ( my $groupingId = shift @{ $groupingIds } ) { + GROUPINGID: while ( my $groupingId = shift @{ $groupingIds } ) { my $group = WebGUI::Group->new( $self->session, $groupingId ); + next GROUPINGID unless $group; for my $groupGroupingId ( @{ $group->getGroupsFor } ) { if ( !$groupIds{ $groupGroupingId } ) { push @{ $groupingIds }, $groupGroupingId;